Repository navigation
Backport changes in configuration.py, api_client.py, and rest.py to swagger-codegen #341
Description
For velocity, we changed these files and disabled generation for them, but it is now time to backport changes to swagger-codegen so we can use the latest generator. These are items that need to be backported:
- config.http_proxy_url is now config.proxy (already exists in upstream). Release Note:
config.http_proxy_url is deprecated. use configuration.proxy instead. - (rest.py) port configuration.assert_hostname to upstream ([Python] Add configuration.{connection_pool_maxsize, assert_hostname} swagger-api/swagger-codegen#6508)
- (rest.py) port configuration.connection_pool_maxsize to upstream (with multiprocessing.cpu_count() * 5 default value) ([Python] Add configuration.{connection_pool_maxsize, assert_hostname} swagger-api/swagger-codegen#6508)
- (api_client.py) Upstream file does not have callback anymore, cleanup documentation in upstream about it ([Python] Add configuration.{connection_pool_maxsize, assert_hostname} swagger-api/swagger-codegen#6508)
- (api_client.py) Remove ws_client from this file. We probably need to make a separate utility like Watch for exec/attach calls (with its out ws_streaming_protocol config). Use stream module to call exec/attach calls #344
- (configuration.py) upstream configuration is not a singleton anymore, add a default configuration to upstream ([python] Add default Configuration swagger-api/swagger-codegen#6554).
- ws_client should not expect any customized config (such as ws_streaming_protocol) from configuration class.
- (requirements*.txt) let the generator generate these files and then add changes to main requirement files.
- (configuration.py) no upstream api_client config. validate the change for our client.
- consider enabling asyncio feature of python generator (support for asyncio #323, feat: add examples for asynchronous usage (callback, asycio) #324)
- update generator version to latest and validate generated client.
- config.http_proxy_url is deprecated. use configuration.proxy instead.
- Exec and attach calls does not return a streaming object anymore. Use kubernetes.stream instead
- Configuration is not a singleton object anymore. Please use Configuraion.set_default to change default configuration.
- Configuration class does not support `ws_streaming_protocol` anymore. Use ApiClient.set_default_header for `sec-websocket-protocol` to have the same effect.
Activity
fejta-bot commentedon Apr 21, 2019
Issues go stale after 90d of inactivity.
Mark the issue as fresh with
/remove-lifecycle stale.Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale
fejta-bot commentedon May 21, 2019
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with
/remove-lifecycle rotten.Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with
/close.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
fejta-bot commentedon Jun 21, 2019
Rotten issues close after 30d of inactivity.
Reopen the issue with
/reopen.Mark the issue as fresh with
/remove-lifecycle rotten.Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close
k8s-ci-robot commentedon Jun 21, 2019
@fejta-bot: Closing this issue.
Details
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.