Repository navigation
Multi-chord phrases (e.g. "Ctrl+K, Ctrl+C") can be parsed but never bound, looked up or executed #135
Description
What's missing
Phrase is a public type with parsing support: Phrase.Parse, Phrase.FromStrings and IKeybindingService.ParsePhrase. The binding model, though, only holds single chords:
Profile.Chordsis aDictionary<string, Chord>(Keybinding/Models/Profile.cs:73).- Every
KeybindingServicebind, find and execute API takes aChord. - The JSON repository stores one chord per command.
Nothing can bind a phrase to a command or match input against one. There is also no way to track a partially typed sequence, where a prefix chord is pressed and the next chord is awaited.
The documentation says otherwise:
- CLAUDE.md says profiles "Store mappings from
CommandIdtoPhrase". - README.md:239 says the demo shows "Phrase binding and lookup".
Keybinding.Demo/MusicalDemo.cs:37-39buildsCtrl+R, RandCtrl+K, Ctrl+Cphrases, but it only prints them.
Why it matters
Chord sequences such as VS/VS Code-style Ctrl+K, Ctrl+C are the headline example for the Phrase type. A consumer who follows the docs will find they can't be used. #134 (a phrase string silently parsed as a single chord) makes this worse, because the attempt fails without any error.
Suggested scope / acceptance criteria
- Store a
Phraseper command. A single chord is a one-chord phrase, so existing chord APIs keep working as thin wrappers. - Add
BindPhrase(commandId, phrase),FindCommandByPhrase(phrase), and a way to execute a phrase. - Optionally, add prefix matching so a host can tell "sequence in progress" from "no match".
- Serialise bindings as a list of chords, and keep reading the existing single-chord
{"notes":[...]}format. - If this isn't planned, correct the CLAUDE.md, README and demo claims instead.
Activity
matt-edmondson commentedon Sep 27, 2026
Triage
Phrase, but single-chord bindings work. The documentation mismatch should be fixed either way.Profile,KeybindingService, JSON repository). Owner: @matt-edmondson. The scope needs a design decision: phrase storage with backward-compatible serialisation, plus optional prefix matching.Phrasestorage while still reading the existing{"notes":[...]}format. If not, correct the docs and demo.Generated by Claude Code
matt-edmondson commentedon Sep 28, 2026
Decision (maintainer, 2026-09-28)
Phraseper command, with single chords as one-chord phrases so the existing chord APIs remain thin wrappersBindPhrase,FindCommandByPhraseand phrase execution{"notes":[...]}formatNext reader: land #134, then implement the above. Coordinate the serialisation change with #93, which is moving persistence to
ktsu.AppDataStoragewith a format migration, so there is one format change rather than two. Make the demo exercise real phrase binding.Generated by Claude Code