Repository navigation
Fix shared generator and serializer failure modes - #146
Merged
Merged
Conversation
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| public void LanguageGeneratorsDoNotBuildCommentPrefixesAroundCallerText() | ||
| { | ||
| string directory = FindRepositoryRoot(); | ||
| foreach (string path in Directory.GetFiles(Path.Combine(directory, "Coder", "Languages"), "*.cs")) |
| { | ||
| for (DirectoryInfo? directory = new(AppContext.BaseDirectory); directory is not null; directory = directory.Parent) | ||
| { | ||
| if (Directory.Exists(Path.Combine(directory.FullName, "Coder", "Languages"))) |
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
Comment on lines
+610
to
+617
| foreach (string import in required) | ||
| { | ||
| if (SpellImport(import) is string spelled) | ||
| { | ||
| code.WriteLine(spelled); | ||
| wroteImport = true; | ||
| } | ||
| } |
Comment on lines
+86
to
+92
| foreach (Parameter parameter in function.Parameters) | ||
| { | ||
| if (parameter.Name is string name && parameter.Type is TypeReference type) | ||
| { | ||
| types[name] = type; | ||
| } | ||
| } |
Co-authored-by: matt-edmondson <19528727+matt-edmondson@users.noreply.github.com>
| } | ||
|
|
||
| if (field.InitialValue is not null) | ||
| if (field.InitialValue is not null && instanceInitialisedFields?.Contains(field) != true) |
| public void Deserializer_UsesTypedReadersForScalars() | ||
| { | ||
| string root = FindRepositoryRoot(); | ||
| string source = File.ReadAllText(Path.Combine(root, "Coder", "Serialization", "YamlDeserializer.cs")); |
| { | ||
| for (DirectoryInfo? directory = new(start); directory is not null; directory = directory.Parent) | ||
| { | ||
| if (File.Exists(Path.Combine(directory.FullName, "Coder", "Serialization", "YamlDeserializer.cs"))) |
Copilot
AI
changed the title
[WIP] Fix the #130–#137 generator/serializer cluster
Fix shared generator and serializer failure modes
Oct 1, 2026
matt-edmondson
marked this pull request as ready for review
October 2, 2026 03:52
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared gaps in preamble handling, comment emission, YAML deserialization, and type inference caused declarations or values to be dropped, corrupted, or emitted as invalid code.
Annotation arguments now serialize as structured YAML while argument-free annotations remain scalar: