Conversation
This is required to be able to pass it off to a global log hook. I know we now have a bunch of `Arc<Mutex<..>>` stuff in this codebase and I need to clean it up. For now, it's not a blocking issue, though. Additionally, this internal mutability switch trades in a few `mut` usages for more `?`.
Owner
Author
|
This includes a bunch of breaking changes. See commit messages for more info on refactoring work. Arc-Mutex fun should be refactored at some point, with increasing importance :) |
Thanks to the previous refactoring, we can now write
log::set_boxed_logger(Box::new(self.clone()))?;
as well as implement the `Log` trait pretty easily.
I have added a simple LogMessage style, but ideally, the user would be
able to tweak this. It shouldn't be too hard -- I imagine supplying a
type `T: FromLogRecord` (or similar) to a `use_as_logger_with_format`
method.
Owner
Author
|
Let's go with this for now, and optimize of after releasing 0.2. |
Owner
Author
|
Ah wait, let's make this optional features before merging |
This reminds me to review the error reporting and make it more consistent. The InnerError should ideally not carry data at all but be concrete error cases we want to set as contexts.
Owner
Author
|
Alright, even upgraded to using the 2018 edition! Let's land this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #4