Repository navigation
fix: make the documented import path work; add pointer helpers - #2
Merged
Merged
Conversation
The package lived in src/, so `import "github.com/keymint-dev/keymint-go"` (used in the README and docs) failed with "no required module provides package". Move the package to the module root. - src/ keeps compiling as a deprecated forwarding package (type aliases and function vars) so existing .../keymint-go/src imports don't break. - Add String, Int and Bool pointer helpers for optional fields; docs already call keymint.String for ActivateKeyParams.HostID. - CI compiles a consumer of both import paths; live tests run from the root.
Member
Author
|
Reviewed 2026-10-17: |
catsika
force-pushed
the
fix/module-root-import
branch
from
October 17, 2026 23:42
58bcf00 to
e33244f
Compare
catsika
marked this pull request as ready for review
October 17, 2026 23:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The README and docs say
import "github.com/keymint-dev/keymint-go", but the package lives insrc/. That import fails withno required module provides package github.com/keymint-dev/keymint-go. The docs also usekeymint.String(...)forHostID, which doesn't exist.Change
src/stays as a deprecated forwarding package (type aliases + function vars), so existing.../keymint-go/srcimports keep compiling.String,IntandBoolpointer helpers.go test .).Testing
gofmt,go vetandgo test ./...pass.replace, with the root import and with the legacy/srcimport.Release
After merge, tag v1.6.0 (additive;
/srcstill works). The Keymint docs will switch to the root import once the tag exists.