Default to Firecracker - #361
Open
sjmiller609 wants to merge 1 commit into
Open
Conversation
sjmiller609
force-pushed
the
hypeship/default-firecracker-linux
branch
from
August 6, 2026 15:27
dbdb4bd to
16e3470
Compare
sjmiller609
force-pushed
the
hypeship/default-firecracker-linux
branch
from
August 6, 2026 15:27
16e3470 to
0fe2681
Compare
sjmiller609
marked this pull request as ready for review
August 6, 2026 15:28
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0fe2681. Configure here.
|
|
||
| Hypervisor: HypervisorConfig{ | ||
| Default: "cloud-hypervisor", | ||
| Default: "firecracker", |
There was a problem hiding this comment.
Darwin default hypervisor unsupported
Medium Severity
The default Hypervisor.Default was changed to firecracker. On macOS (Darwin), firecracker is not a registered VM starter. This causes instance creations that rely on the default hypervisor to fail on macOS, reporting no VM starter for firecracker.
Reviewed by Cursor Bugbot for commit 0fe2681. Configure here.
hiroTamada
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
testing
GOCACHE=/tmp/hypeman-go-build go test ./cmd/api/configNote
Medium Risk
Switching the default hypervisor changes VM runtime behavior for new or minimally configured deployments; operators who expected Cloud Hypervisor must set
hypervisor.defaultexplicitly.Overview
Changes the built-in default for
hypervisor.defaultfromcloud-hypervisortofirecrackerindefaultConfig()(cmd/api/config/config.go).Hosts that rely on defaults (no YAML override and no
HYPERVISOR__DEFAULTenv) will now provision and run VMs with Firecracker instead of Cloud Hypervisor. Existing configs that set the hypervisor explicitly are unchanged.Reviewed by Cursor Bugbot for commit 0fe2681. Bugbot is set up for automated code reviews on this repo. Configure here.