Generate SDKs with self-hosted stlc - #344
Merged
Merged
Conversation
sjmiller609
force-pushed
the
hypeship/stlc-sdk-generation
branch
2 times, most recently
from
August 4, 2026 18:28
0058a2e to
46886c1
Compare
-->
✱ stlc build✅ go code · compare
✅ typescript code · compare
Diagnostics: 💡 0 new / 5 total note
Build metadata
This comment is auto-generated by stlc and is kept up to date as you push. |
sjmiller609
force-pushed
the
hypeship/stlc-sdk-generation
branch
from
August 4, 2026 18:33
46886c1 to
2343f86
Compare
sjmiller609
force-pushed
the
hypeship/stlc-sdk-generation
branch
from
August 4, 2026 20:08
2343f86 to
7d8cb25
Compare
sjmiller609
marked this pull request as ready for review
August 5, 2026 15:23
sjmiller609
commented
Aug 5, 2026
sjmiller609
left a comment
Collaborator
Author
There was a problem hiding this comment.
Strict review of head aa60130 — verdict: approve (cannot submit a formal GitHub approval as the PR author).
- Runbook docs/runbooks/sdk-generation-stlc.md covers all durable ops: staging previews, main generation, manual Promote SDKs fast-forward promotion (verified in hypeman-*-staging stlc-promote.yml: workflow_dispatch only, ancestor check refuses divergence, never force-pushes), release-please + scheduled back-sync (stlc-sync.yml), integration-test safety/cleanup, custom-code sealing/tracking, recovery commands, pinned stlc revision upgrades, delayed hosted-app removal.
- Removed content is one-time cutover/setup history only; workflow header comment updated accordingly.
- All checks pass; no unresolved review threads.
rgarcia
approved these changes
Aug 5, 2026
rgarcia
left a comment
Contributor
There was a problem hiding this comment.
reviewed — overall flow looks solid; two things worth addressing:
correctness
.github/workflows/stlc-generate.yml:235-236— the clean-worktree validation misses untracked files. consider checkinggit status --porcelain --untracked-files=allso bootstrap or test artifacts cannot affect the pushed build without being detected.
docs
docs/runbooks/sdk-generation-stlc.md:39-48— the operator commands do not establish thestainless/working directory, although CI invokesstlcthere. consider addingcd stainlessbefore the build and recovery commands so the snippets work from a fresh checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Go and TypeScript SDKs from hosted Stainless generation to self-hosted
stlc.stlcpackages at exact commit SHAs on Node.js 24Validation
mainAfter merge
The merge triggers generation onto staging
main. Review the staging changes, manually run each staging repository'sPromote SDKsworkflow, then verify release-please, package publishing, and production-to-staging back-sync before removing hosted-only secrets or uninstalling the Stainless GitHub App.Note
High Risk
This changes how published Go/TypeScript SDKs are built and pushed (new secrets, app tokens, staging vs production repos); mistakes could ship wrong SDK output or drop custom code if seal-back tracking lags.
Overview
Replaces the hosted Stainless GitHub Action workflow with a self-hosted
stlcpipeline that builds Go and TypeScript SDKs from this repo’s OpenAPI/Stainless config.A new composite action installs pinned
stlcCLI and generator packages (Node 24, Go, pnpm) using a private read token.stlc-generate.ymldrives PR preview branches on staging SDK repos, posts anstlc showmanifest comment, validates with bootstrap/lint/test, pushes stagingmainon merge, opens auto-merge PRs forstainless/custom-codetracking files, and cleans up preview branches when PRs close.workflow_dispatchwithintegration_testpushes isolated test branches and draft PRs without touching production paths.stainless.yamlnow declaresstaging_repoand release publish settings per target. The repo adds astainless/workspace (workspace.json, committed custom-code tracking JSON, gitignore for generatedsdks/andbuilds/). Operator flow is documented indocs/runbooks/sdk-generation-stlc.md.Reviewed by Cursor Bugbot for commit 9e93ede. Bugbot is set up for automated code reviews on this repo. Configure here.