Skip to content

docs: no chat quotes on GitHub - #237

Open
manager wants to merge 1 commit into
devfrom
chore/no-chat-on-github
Open

manager wants to merge 1 commit into
devfrom
chore/no-chat-on-github

Conversation

@manager

@manager manager commented Sep 12, 2026

Copy link
Copy Markdown
Contributor

A rule for this public repository: no quoted chat, no authorization words, no private voice in PR bodies, commit messages, issues or reviews. Write "authorized by Wolf on " and stop.

🤖 Generated with Claude Code

@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Claude finished @manager's task in 49s —— View job


Reviewing PR #237

  • Gather context (diff, CLAUDE.md content)
  • Understand request (docs-only change review)
  • Review the diff for correctness/conventions
  • Post summary

Summary

This PR only touches CLAUDE.md, appending one bullet to the existing "This repository is public" section (no code changes), so the React/TS/a11y/security/styling review categories in my instructions don't apply here — this is a documentation-only review.

Content check:

  • The new bullet is internally consistent with the rest of the file: it reuses established terms (--go from the A-Z ownership grant, "release journal" from the release-lessons section) rather than inventing new vocabulary.
  • It's appended as a bullet under the existing ## This repository is public heading rather than a new ## section, which fits the PR title's intent and keeps the file's structure (one heading per incident-driven policy) intact.
  • The factual claim that PR body edit history stays publicly visible on GitHub (so a leaked revision needs deletion by an admin, not just a re-edit) is accurate and is useful operational guidance for whoever hits this in practice.
  • No secrets, private infra details, or quoted chat are introduced by the change itself — it only describes the policy, consistent with what it's asking for.

No issues found. This is a clean, low-risk documentation change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@manager manager changed the title docs: nothing Wolf said goes to GitHub docs: no chat quotes on GitHub Sep 12, 2026
@manager
manager force-pushed the chore/no-chat-on-github branch from 541c6eb to 5bdafde Compare September 12, 2026 07:27
@github-actions

github-actions Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Claude finished @manager's task in 2m 4s —— View job


Reviewing PR #237

  • Gather context (diff, CLAUDE.md content)
  • Understand request (docs-only change review)
  • Review the diff for correctness/conventions
  • Post summary

Summary

This PR only touches CLAUDE.md, appending one bullet under the existing "This repository is public" section — no app code, so the React/TS/a11y/security/styling categories in my instructions don't apply here; this is a documentation-only review.

Content check:

  • The rule itself is clear and self-consistent: it doesn't quote chat verbatim while describing the "no quoted chat" policy, so it complies with what it's asking for.
  • Placement under "This repository is public" fits the theme (public-surface hygiene), even though the section's intro talks about "committed lines," not PR/issue/review prose — a minor scope stretch, not a defect.
  • One real gap, left as an inline comment: the new bullet says Wolf's words "live in the keepsimple-ctl journal and the private release journal only," but "keepsimple-ctl journal" isn't a term defined anywhere in this repo. The only named journal elsewhere in CLAUDE.md is the "release journal" (Release lessons section); the A-Z Ownership section just says "left in the journal" without naming it. As written, an agent following this rule has no concrete place to actually record Wolf's authorization words for one of the two journals named.

No other issues found — formatting and voice match the rest of the file.

Comment thread CLAUDE.md
- Nothing Wolf said goes to GitHub: no quoted chat, no `--go` words, no
private voice in a PR body, commit message, issue or review. Write
"authorized by Wolf on <date>" and stop. His words live in the
keepsimple-ctl journal and the private release journal only. On

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"keepsimple-ctl journal" isn't a term this file defines anywhere else. The A-Z Ownership section (line 147) only says Wolf's go is "left in the journal" without naming which one, and the only named journal in this file is the "release journal" from the Release lessons section (line 58) — a different concept (build/rollout timing, not authorization words). wolfs-server/docs/keepsimple-ctl.md isn't in this repo, so there's nothing to check the name against either.

As written, an agent following this rule has no concrete answer for "where do I actually record Wolf's authorization words" — it's pointed at two things, one of which doesn't exist under a defined name in this repo. Consider either reusing the established "release journal" term or adding one line defining what the "keepsimple-ctl journal" is (a MemPalace drawer? a keepsimple-ctl subcommand? a file path?).

Fix this →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant