Repository navigation
chore(grpc-gateway): drop dep files and deprecated grpc.Dial - #141
Merged
Merged
Conversation
Remove Gopkg.toml/Gopkg.lock and the `dep ensure` Makefile target, which are leftovers from before the move to Go modules. Replace the deprecated grpc.Dial and grpc.WithInsecure in the gateway with grpc.NewClient and insecure credentials. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grpc-gateway に残っていた Go modules 移行前の名残と、非推奨 API を整理します。
Gopkg.toml/Gopkg.lockを削除 (grpc-gateway はルートの go.mod で管理されている)Makefileのprepareターゲット (dep ensure -v) を削除gateway/main.gogrpc.Dial(deprecated) →grpc.NewClientgrpc.WithInsecure()(deprecated) →grpc.WithTransportCredentials(insecure.NewCredentials())grpc.NewClientはデフォルトの name resolver がpassthroughではなくdnsになりますが、ENDPOINTはhost:port形式なので挙動は変わりません。また接続は最初の RPC 時に確立されます。Test
go build ./grpc-gateway/... && go vet ./grpc-gateway/...が通ることを確認GET /alive,GET /user/100,GET /user?group=ADMIN,PUT /user/100(backend 側で update body のログ出力も確認)Makefileを触っていますが、git merge-treeでコンフリクトしないことを確認済み🤖 Generated with Claude Code