Skip to content

Ignore non-finite parsed Max-Age values - #289

Open
offyotto wants to merge 1 commit into
jshttp:masterfrom
offyotto:fix/finite-parsed-max-age
Open

offyotto wants to merge 1 commit into
jshttp:masterfrom
offyotto:fix/finite-parsed-max-age

Conversation

@offyotto

Copy link
Copy Markdown

Guard numeric conversion with Number.isFinite. Oversized decimal attributes currently produce ±Infinity and overwrite a prior valid Max-Age. Adds overflow and duplicate-attribute regressions. Verified: 63,743 Vitest cases, TypeScript build/typecheck, 1.27 kB bundle (1.4 kB limit). Independent of serializer validation in #286.

@codecov

codecov Bot commented Oct 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4898ba2) to head (f1d76f5).
⚠️ Report is 40 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #289   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          160       195   +35     
  Branches        69        84   +15     
=========================================
+ Hits           160       195   +35     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant