Repository navigation
Pagination Support #20
Description
That's more a question to the maintainer(s). Any plans to implements pagination or should this be handled outside the package? At least we need to implement a way to get the headers. Some guidance would be great, I need pagination in one of my projects and have it implemented, but it can't be done without a B/C break. Form what I can see in the 2.0-branch it is still not possible to paginate the results. So the options I see are:
- just return to response object and let the outside class handle pagination
- implement a pagination class and return body and pagination object
Either way is fine, if I know what is the preference I could work on a PR.
Activity
mbabker commentedon Nov 23, 2015
#19 shows how easy it is to make the change (actually unless something isn't using that processResponse method it's already 100% done), the long part is in changing the unit test infrastructure.
FWIW I've taken the same type of approach I proposed on #19 in my own package (see BabDev/Transifex-API@1.x...master for the changes, including how to DRY out the duplicated unit test logic).
I've gone ahead and restored the
Return-Responsebranch that RFC was based on. IMO that is the quickest route to make available the data that's being stripped out with the current return structure.rdeutz commentedon Nov 23, 2015
ok, so the answer is: 1)
and let the outside class handle pagination. Good I can check the unit tests.