feat(branding): use the generated deckd mark across every icon surface - #170
Merged
Merged
Conversation
Install the generated 2x2 mark as the single source of truth for icons. The raw assets had a stray generator suffix (`_SiNR`); renamed to plain `deckd-logo`/`deckd-mark` names and copied the 2x2 art to client/public/icon.svg. - favicon + PWA icon (SVG, plus 192/512 PNG any + maskable) - apple-touch-icon (opaque, full-bleed so iOS's mask doesn't crop) - macOS .app icon: committed deckd.icns, defaulted in the PyInstaller spec - menu-bar status item: monochrome template image (3 dim + 1 active tile), with an SF Symbol and text-title fallback Adds `just icons` to regenerate everything from the SVG via the e2e Chromium and iconutil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts the generated 2x2 deckd mark as the single source of truth for every icon surface. The raw assets carried a stray generator suffix (
_SiNR), so they are renamed to plaindeckd-logo/deckd-marknames.client/public/icon.svg(favicon +anymanifest icon), plus rasterisedicon-192/512.png(any) andicon-maskable-192/512.png(maskable).packaging/macos/deckd.icns(16→1024), now the spec default (DECKD_ICONstill overrides).deckd-menubar.png+@2x), so macOS tints it for light/dark. Falls back to SF Symbolsquare.grid.2x2, then thedeckdtext title.just icons— regenerates every PNG/icns above from the SVG using the e2e Chromium +iconutil(no new dependencies).Notes
anymark's rounded-rect background and corner tiles would be clipped by a mask, so the maskable variant pulls the tiles into the safe circle.menubar_icon_pathsresolves both frozen (sys._MEIPASS) and source (packaging/macos) layouts.LSUIElement(menu-bar only), so the.icnsshows in Finder/Get Info/notifications — there is no Dock icon.Test plan
pytest tests/test_app.py— 9 passed (incl. 3 newmenubar_icon_pathscases)python -m py_compileonmenubar.py/macos_app.py; spec parsesnpm run lintandnpm run buildinclient/just iconsend-to-end (PNGs +.icns)deckd.appon a retina Mac (not doable in CI)