Repository navigation
Oscar - #169
Oscar#169johnno1962 wants to merge 2 commits into
Conversation
|
Testing held up by not being able to build InjectionNext with Xcode 27. |
6639835
left a comment
6639835
left a comment
There was a problem hiding this comment.
[P2] Preserve literal filenames when parsing git check-ignore output
The pinned InjectionLite update invokes git check-ignore --stdin and collects output as literal lines in GitIgnoreParser.swift:266–272, then compares them against original paths at line 224. Git quotes filenames containing non-ASCII bytes, tabs, or quotes; an ignored 日本.swift produces a quoted path with octal escapes and fails ignoredFiles.contains(file). It is then cached as not ignored, allowing ignored source files into monitoring. A local reproduction with *.swift in .gitignore returned Git status 0 but an emitted path unequal to the submitted path. Please use NUL-delimited input/output (-z) with appropriate parsing and add a Unicode/special-character filename regression.
Reviewed the parent diff at e7ae0a5 and its substantive submodule update. Static code review with the Git reproduction; the Swift suite was not run.
2 participants
No description provided.