Skip to content

fix: avoid []byte copy in extractKeyValue #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joaooncode merged 1 commit into from
Sep 12, 2026
Merged

fix: avoid []byte copy in extractKeyValue #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/secretscanner/secretscanner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"math"
"path/filepath"
"regexp"
"strings"
)

// Method identifies which detection technique produced a Match.
Expand Down Expand Up @@ -180,7 +181,7 @@ func (s *Scanner) Scan(content []byte) ([]Match, error) {

// extractKeyValue splits a "KEY=VALUE" line into its key and value, if present.
func extractKeyValue(line string) (key string, value string, ok bool) {
idx := bytes.IndexByte([]byte(line), '=')
idx := strings.IndexByte(line, '=')
if idx < 0 {
return "", "", false
}
Expand Down