Repository navigation
[ac#990] 删除已下线的产物工作台整页组件 - #1489
Merged
Merged
Conversation
#662 已摘掉入口与全页挂载,ArtifactWorkbench 组件本体与其页面级 CSS 仍留在树上、零挂载点。 - 删除 artifact-workbench/artifact-workbench.tsx(ArtifactWorkbench 组件) - 会话右栏仍复用的 MetadataView / STATE_LABEL_KEYS / TAB_LABEL_KEYS 原样迁到 artifact-workbench/metadata-view.tsx,artifacts-panel-view.tsx 改 import 路径 - artifact-workbench.css 删掉只服务整页的选择器(页壳/页头/三栏/run 列/用量/panel 等), 卡片、chip、页签、预览与 renderers 通用元件保持逐字不变 Refs #970, #662 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JaBLPMtJZWAetynFgsDXMX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
「产物工作台」整页界面 7 月底已下线,入口早已摘掉,但约 700 行界面代码和它专用的样式还留在仓库里。这次把它删掉。用户能看到的东西一处都不变:会话右侧栏「产物」面板还在借用的几个小零件(详情视图、状态与页签文案)原样搬到一个新的小文件里,卡片、状态标签、预览页签这些样式也一条没动。删掉以后,就不会再有人照着这段没人用的旧代码去抄写法了。
工程细节
改动文件(全部在
packages/ui-mac,零上游文件)src/renderer/alpha-ui/artifact-workbench/artifact-workbench.tsx(ArtifactWorkbench组件本体)。src/renderer/alpha-ui/artifact-workbench/metadata-view.tsx:MetadataView、STATE_LABEL_KEYS、TAB_LABEL_KEYS逐字搬入,并承接import "./artifact-workbench.css"(此前 CSS 是经被删组件间接加载给右栏的)。session-rail/artifacts/artifacts-panel-view.tsx:只改 import 路径。artifact-workbench.css:删掉只服务整页的选择器 ——[data-alpha-workbench]、.alpha-wb-page、页头/项目选择/关闭按钮、三栏.alpha-wb-body(含媒体查询)、.alpha-wb-runs/cards/col-title、run 列表.alpha-wb-runlist/runrow/runid/runmeta、用量.alpha-wb-usage*、.alpha-wb-panel、.alpha-wb-toolbar。甄别方法:CSS 中每个类名在src/**/*.{ts,tsx}(除被删文件外)与MetadataView内都零命中才删;其余选择器逐字不变。workbench-state.ts保留:其recall/rememberSelection仍被workbench-core.test.ts引用,不在本票范围内动。检查(沙箱,与 origin/alpha 基线对比)
session-rail全部测试(含session-rail-artifacts.test.ts宿主与其子进程 cases):105 pass / 0 fail。ext0 错、alpha-contracts-consumer0 错;ui-mac9 错全部在../app/src/components/terminal.tsx/addons/serialize*,原因是ghostty-web在沙箱代理 403 装不上(沙箱特有)。bun test src(ui-mac):5280 条中 32 fail —— 全部失败文件在 stash 掉本改动后对基线重跑,失败用例集合一致(26 vs 26,只差一条基线侧的抖动用例);均为 root 运行导致 EACCES 用例失效、Linux 平台降级、网络/真引擎探测等沙箱原因,与产物面无关。scripts/assert-gate-files.sh:失守的 8 个闸门文件(alpha-models、ext-config、stream-read-hygiene、worktree-probe-sweep、alpha-session-search、shell-commands、start-draft、surface-remount)在基线上同样失败,均不涉及本改动。--no-verify说明:上游 husky pre-push 跑全量turbo typecheck,在沙箱里 turbo 直接 SIGBUS 崩溃(且 ghostty-web 缺包),属沙箱特有原因,按授权用--no-verify推送;请 owner 合并前在本地重跑全部门禁。Fixes #990
🤖 Generated with Claude Code
https://claude.ai/code/session_01JaBLPMtJZWAetynFgsDXMX
Generated by Claude Code