Repository navigation
fix(gate): alpha tip 是红的 —— 上游 sync 打红两道闸,每条 lane 的 push 都被拦 - #1450
Merged
Merged
Conversation
`57646831b` 这次 sync 把两条上游改动带进 alpha,各打红一道本机闸门。今晚三条 独立 lane(`#1433` / `#1445` / `#1448`)各自撞上同一对红,全都 push 不出去 —— 这不是谁的改动坏了,是 base 本身红。 **一、`debug config` 现在给凭证打码** 上游 `82d4c8903 fix(opencode): redact credentials in debug config (anomalyco#50956)` 起, `redactConfig()` 会把 `headers` 下的每个字符串值换成 `"***"`,且**没有开关** (`packages/opencode/src/cli/cmd/debug/redact.ts`;同一 commit 顺带删掉了 `builder: (yargs) => yargs`)。 `mcp-server-derivation.test.ts` 的 ③ 那一格用 `debug config` 读回真引擎合并后的 配置,于是断言 `X-Token: "t"` 恒红。 **改成断言脱敏后的形状,而不是把这一格删掉或放宽**: - 这一格真正要判的是「连接字段以真源为准」—— 靠的是 `url`(真源 `mcp.example.com` 压过 XDG 的 `user-global.example`),而 `redactConfig` 只在 URL 带用户名/口令/ 敏感 query 时才动 url,这里逐字未脱敏,判据完好; - 头部的**真实值**在 ① 那一格仍被逐字断言,那一格读的是我们自己的注入面、不经引擎。 所以「值有没有原样传下去」并没有因为这次改动失去判官。 **二、`transform.test.ts` 的用例数被上游加了 24 条** 登记 561,实测 585。`git diff 5764683^1 5764683` 对该文件**纯增量**(零条 `test(` / `it(` 被删),与前两次同步的形态一致(368 → 411 → 561)。按脚本自己的 `--update` 写回,all-or-nothing,diff 恰好一行。 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
为什么开这张 PR
今晚三条独立 lane(
#1433/#1445/#1448)各自跑完本机门之后都 push 不出去,红的是同一对测试。逐条查下来不是谁的改动坏了 —— 是
57646831b这次上游 sync把两条改动带进 alpha,各打红一道闸。alpha tip 自己是红的,每条基于它的 lane 都被拦。
三条 lane 的证据互为对照:
#1445在零改动的 base 上跑了一遍门(RC=1),#1448与#1433在各自树上复现同一文件同一行。一、
debug config现在给凭证打码上游
82d4c8903 fix(opencode): redact credentials in debug config (#50956)起,redactConfig()把headers下的每个字符串值换成"***",没有开关(
packages/opencode/src/cli/cmd/debug/redact.ts;同一 commit 顺带删掉了builder: (yargs) => yargs)。mcp-server-derivation.test.ts的 ③ 用debug config读回真引擎合并后的配置,于是
X-Token: "t"恒红。改成断言脱敏后的形状,而不是删掉或放宽这一格:
url(真源mcp.example.com压过 XDG 的
user-global.example)。redactConfig只在 URL 带用户名/口令/敏感query 时才动 url,这里逐字未脱敏,判据完好;
⇒ 「值有没有原样传下去」没有因为这次改动失去判官。
二、
transform.test.ts被上游加了 24 条用例登记 561,实测 585。
git diff 57646831b^1 57646831b对该文件纯增量(零条test(/it(被删),与前两次同步同形(368 → 411 → 561 → 585)。按脚本自己的--update写回,all-or-nothing,diff 恰好一行。顺带记一条本机陷阱(不在本 PR 的 diff 里,已另记 governance)
scripts/assert-gate-files.sh --update在新建 worktree 里跑不动,因为它要跑全部闸门文件,而 bootstrap 过的树仍缺两个未追踪产物,各有各的指纹:
electron/path.txt+dist/缺失 ⇒process-fence-apply.test.ts恒红(
error: ENOENT … electron/path.txt);native/alpha-fence/build/alpha_fence.node缺失 ⇒process-fence-wiring.test.ts10/12(
process fence: native module missing at …,报错自己点名了scripts/build-fence-addon.ts)。补齐这两个之后
--update一次通过。Refs #1414
🤖 Generated with Claude Code