chore: 8 个文件 13 处注释里的 .alpha/ 改为 .code-puppy(零行为变化) - #1205
Merged
Merged
Conversation
#1192 的改名只落到代码字面量与被它直接覆盖的注释。这 8 个文件的 `.alpha` 代码字面量为 0(路径全部经 alpha-workdir / project-config 取得),注释却仍 写旧址 —— 行为对,注释在骗人。 alpha-builtin-policy.ts:3 是语义错误而非路径过期:它写「真源 = `~/.alpha/governance.json`」,而 :69 实际是 path.join(alphaGlobalRoot(), "governance.json")。改为指 `alphaGlobalRoot()` 这个函数,不写死绝对路径 —— 写死只是把一个会过期的事实换成另一个。 零行为变化:diff 只含注释行。 明确未动(改了会造成缺陷,且没有任何测试会红): - join(home, ".alpha") 的 8 处退役守卫 —— project-config.ts:30,77,90 / alpha-environment.ts:288,299 / alpha-workdir.ts:128 / engine-config-dangling.ts:200 / engine-config-truth-boot.ts:243。 它们的职责是认出旧址并拒绝/清理。 - cloud-dispatch-gate.cases.ts:28 的 HISTORICAL_INJECTED_DENIED_PATHS。 Refs #1202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1202
.code-puppy改名(#1192)只落到代码字面量与被它直接覆盖的注释。本 PR 涉及的 8 个文件里,.alpha的代码字面量为 0(路径全部经alpha-workdir/project-config取得),而 13 处注释仍写旧址 —— 行为对,注释在骗人。零行为变化。
改动清单(文件:行,全部为注释行)
packages/ext/src/plugin-fanout.ts:1<dir>/.alpha/plugins/*.js→.code-puppypackages/ext/src/plugin-fanout.ts:53.alpha/plugins/*.js→.code-puppypackages/ui-mac/src/main/alpha-ext-trust.ts:3.alpha/alpha.jsonc+.alpha/plugins/*.js→.code-puppy(同一行两处)packages/ui-mac/src/main/alpha-ext-trust.ts:4.alpha/prefs.json→.code-puppypackages/ui-mac/src/main/cloud-ipc.ts:113<directory>/.alpha/runs/…→.code-puppypackages/ui-mac/src/main/cloud-ipc.ts:188<directory>/.alpha/runs/…→.code-puppypackages/ui-mac/src/main/claude-plugin-install.ts:95<project>/.alpha/skills→.code-puppypackages/ui-mac/src/main/alpha-cloud-schedules.ts:5.alpha/runs/→.code-puppypackages/ui-mac/src/main/alpha-cloud-schedules.ts:135.alpha/runs/→.code-puppypackages/ui-mac/src/main/alpha-bridge.ts:1`.alpha`→`.code-puppy`packages/ui-mac/src/main/alpha-bridge.ts:2<project>/.alpha→.code-puppypackages/ui-mac/src/main/alpha-installs.ts:7<projectDir>/.alpha→.code-puppypackages/ui-mac/src/main/alpha-builtin-policy.ts:3~/.alpha/governance.json→`alphaGlobalRoot()/governance.json`最后一条不是路径过期而是语义错误:
:69实际是path.join(alphaGlobalRoot(), "governance.json"),而
~/.alpha按 ADR-019 修订已退役。注释改为指向那个函数,不写死任何绝对路径 ——写死只是把一个会过期的事实换成另一个。
明确未动(改了会造成缺陷,且没有任何测试会红)
join(home, ".alpha")的 8 处退役守卫 —— 职责是认出旧址并拒绝/清理,改名会让守卫指向不存在的路径。逐行与
origin/alpha做字节比对,9/9SAME:packages/ext/src/project-config.ts:30,77,90packages/ui-mac/src/main/alpha-environment.ts:288,299packages/ui-mac/src/main/alpha-workdir.ts:128packages/ui-mac/src/main/engine-config-dangling.ts:200packages/ui-mac/src/main/engine-config-truth-boot.ts:243packages/ui-mac/src/main/cloud-dispatch-gate.cases.ts:28的HISTORICAL_INJECTED_DENIED_PATHS这 6 个文件一个都不在本 PR 的
--name-only里。退出条件 2 的自证:diff 只含注释行
空输出正是这里的期望结论,所以先证明这条命令测得出已知的坏 —— 临时把
project-config.ts:30的退役守卫join(home, ".alpha")改成".code-puppy"并提交,同一条命令给出:
随后
git reset --hard回到实验前的361d49f64(SHA 逐字相同、git status空、被变异那行已还原),重跑同一条命令再次为空。
本机门(逐道单独取退出码,
set -o pipefail)bash scripts/north-star-guard.shrc=0—✓ zero upstream package editsbun run --cwd packages/{alpha-contracts-consumer,ext,ui-mac,opencode} typecheckrc=0,error TS计数各 0bash scripts/bun-test-floor.sh 15 packages/alpha-contracts-consumerrc=0— 60 pass / 0 fail / 6 filesbash scripts/bun-test-floor.sh 100 packages/extrc=0— 161 pass / 0 fail / 15 filesALPHA_KNOWN_FAILS_FILE=scripts/known-fails.tsv bash scripts/bun-test-floor.sh 3000 packages/ui-mac srcrc=0— 4654 pass / 0 fail / 327 files / 219.8sbash scripts/bun-test-floor.sh 496 packages/opencode <13 files>rc=0— 496 pass / 0 fail / 13 files与 base fail-set 的差:空。ui-mac 全量
0 fail,连known-fails.tsv登记的已知红本轮也没出现;一个空的红集不可能包含 base 之外的成员。opencode 那 13 个文件是
gate-files.tsv里packages/opencode的全部登记项,条数下界 496 = 登记簿逐行条数之和,实测
Ran 496 tests across 13 files(文件数与枚举数相等)。未跑
scripts/alpha-check.sh:它第 [8/9] 步会真建探针 worktree 并写共享.git/config的core.hooksPath,并行 lane 期间会互相制造假红。push 用--no-verify同因(pre-push 整跑 alpha-check)。主动没做的
.alpha陈旧注释没有顺手改。 实测枚举:grep -ranE '\.alpha([^-a-zA-Z0-9_]|$)' packages/*/src(排除*.test.ts/*.cases.ts)共 72 处,票面只覆盖其中 13 处。剩余里至少这些同样是「代码字面量为 0、注释指旧址」:
alpha-cloud-consent.ts:6、automation-types.ts:3、automation-scheduler.ts:8、ext-inventory.ts:237、ext-trust-watcher.tsx:4,5、artifact-workbench.tsx:4,84,95、ext-project-adopt.ts:5,9,43,44、ext-project-residuals.ts:2,14,45、ext-config.ts:428,797、engine-plugin-seal.ts:39、platform/index.ts:7、preload/types.ts:306,331,440,969,999,1061,1072,1167,1178。另有一类不该改的:
alpha-migrate.ts:3、factory-skills.ts:4、cloud-envelope-guard.ts:11记的是历史/已删规则,
index.ts:772是日志字符串字面量不是注释。需要逐条分类,是另一张票,不是本票的顺手活。
~/.opencode/opencode.jsonc这类与.alpha无关的旧址表述。alpha.jsonc文件名(票面 out-of-scope)。