Repository navigation
fix: publish the Homebrew cask - #74
Merged
Merged
Conversation
The v1.9.0 release uploaded its archives and checksums, then failed:
homebrew cask: expected {{ .Env.VAR_NAME }} only
(no plain-text or other interpolation)
GoReleaser accepts exactly that form for a tap token and rejects any
other, including {{ index .Env "VAR" }}, which is what the config used.
The check runs when publishing, so goreleaser check and a snapshot
build both accepted the wrong form -- neither local check could have
caught this, and only a real release can confirm the fix.
skip_upload keeps the index form, which is not subject to the rule and
does not fail when the variable is unset. The token resolves because
the workflow always sets the variable, to the empty string when the
secret is missing, and skip_upload stops the upload before the token
is used.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
=======================================
Coverage 96.96% 96.96%
=======================================
Files 5 5
Lines 462 462
=======================================
Hits 448 448
Misses 14 14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The v1.9.0 release uploaded its archives and checksums, then failed:
GoReleaser accepts exactly that form for a tap token and rejects any other, including
{{ index .Env "VAR" }}, which is what the config used.Why nothing caught it
The rule is enforced when publishing. Both local checks passed the broken config:
goreleaser checkgoreleaser release --snapshotSo this PR cannot be verified locally. The only proof is the next tagged release, and the
run log now reports whether the cask published.
What v1.9.0 did and did not ship
Published and valid — nothing needs re-releasing:
Not published: the Homebrew cask.
jferrl/homebrew-tapstill contains only its README, sobrew install jferrl/tap/githubauthdoes not work yet.The tap token itself was never the problem. The release log confirms it:
HOMEBREW_TAP_GITHUB_TOKEN is present.Note on skip_upload
skip_uploadkeeps theindexform. It is not subject to this rule and, unlike.Env.VAR, does not fail when the variable is unset. The token reference resolvesbecause the workflow always sets the variable, to the empty string when the secret is
missing, and
skip_uploadstops the upload before the token is used.Type of Change
Testing
goreleaser checkpasses and a snapshot build generates the cask — neither of whichdistinguishes this from the broken version, as above. Tag
v1.9.1to confirm.Documentation
Checklist