Remove unused scripts - #578
Merged
Merged
Conversation
inteon
marked this pull request as draft
September 30, 2024 14:21
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
force-pushed
the
remove_unused_code
branch
from
September 30, 2024 15:18
e406586 to
22ca1e7
Compare
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
inteon
changed the title
inteon
marked this pull request as ready for review
September 30, 2024 15:23
maelvls
reviewed
Oct 1, 2024
Comment on lines
-288
to
-291
| podDisruptionBudget: | ||
| enabled: false | ||
| minAvailable: 1 | ||
| maxUnavailable: 1 No newline at end of file |
Member
There was a problem hiding this comment.
Oops, not sure why I added this...
Ahh, I know: that's because I didn't notice that maxUnavailable: 1 etc existed above. I should have just added +docs:property so that helm-tool detects these three fields.
maelvls
reviewed
Oct 1, 2024
Member
There was a problem hiding this comment.
I forgot to remove that. Thanks for cleaning this up!
maelvls
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #556
Removes the scripts that are no longer used.
Also fixes a bug I found in the values.yaml file: 336a802