Skip to content

Jenkins 41704 fix error when using job's last cppcheck report - #40

Closed
michael-doubez wants to merge 14 commits into
jenkinsci:masterfrom
michael-doubez:JENKINS-41704
Closed

michael-doubez wants to merge 14 commits into
jenkinsci:masterfrom
michael-doubez:JENKINS-41704

Conversation

@michael-doubez

Copy link
Copy Markdown
Contributor

I first though it was due to the mixing of thales and jenkins package.
But in fact, the solution consisted in restoring the reference to the job in CppcheckProjectAction.

I kept all the work done since it cleans things up.

@michael-doubez

Copy link
Copy Markdown
Contributor Author

@marcosteffan can you please review this PR and #39 please ?

I will use this version of the plugin at work but it would be nice to have an official release

@marcosteffan

Copy link
Copy Markdown
Contributor

For me the changes in 07c9b0f seem OK.

Though, I am not sure on the implications of dropping the thalesgroup-stuff. @mixalturek do you have any preferences on that?

@mixalturek

Copy link
Copy Markdown
Contributor

Hi, I no longer work on this plugin.

@michael-doubez

Copy link
Copy Markdown
Contributor Author

I don't know enough about the Jenkins storage system to say f it has an impact or not.
I guess that if some serialisation was done for a Thales class, it may cause the loading to fail.

The only I can think of in what I changed is the ProjectAction. But since the previous development already changed the underlying type from AbstractBuild to Run, I guess it was already broken.

I'll make a try. We may need to make an adaptation to reload correctly existing data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants