Repository navigation
chore(deps): update dependency ruby to v4.0.5 - #42
Conversation
|
PR author is in the excluded authors list. |
|
@renovatebot rebase |
30a88c0 to
ce0b71c
Compare
📝 WalkthroughWalkthroughThe ChangesRuby Version Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~1 minute Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.ruby-version (1)
1-2:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRemove the extra token from
.ruby-version(keep a single version line only).Line 2 (
2) makes the file malformed;.ruby-versionshould contain just the version string. This can break local Ruby version resolution even if CI uses workflow inputs.Suggested fix
4.0.5 -2🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.ruby-version around lines 1 - 2, The .ruby-version file currently contains an extra token on the second line ("2"); edit .ruby-version so it contains only the single version string "4.0.5" (remove the stray "2" or any extra newline/content) to ensure the file is a single-line valid Ruby version specification.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In @.ruby-version:
- Around line 1-2: The .ruby-version file currently contains an extra token on
the second line ("2"); edit .ruby-version so it contains only the single version
string "4.0.5" (remove the stray "2" or any extra newline/content) to ensure the
file is a single-line valid Ruby version specification.
…#61) GitHub links merged pull requests to **issues** through `Closes #N`, but discussions have no equivalent. A discussion that asks for a feature stays open and unlinked after the pull request implementing it merges, so the person who filed it is never told it shipped and the thread has to be closed by hand. This adds a workflow that runs when a pull request merges, scans its body for discussion references, and comments on each referenced discussion with a link back to the pull request. | In the PR body | Effect on the discussion | |---|---| | `Closes #N`, `Fixes #N`, `Resolves #N` | Comment, then close as `RESOLVED` | | `Refs #N`, `Discussion: #N` | Comment only | A PR titled `feat(status): show the last cron start and next scheduled time` whose body ends in `Closes #901` posts this on discussion #901 the moment it merges: > Implemented in [#902](jdx/pitchfork#902): feat(status): show the last cron start and next scheduled time Numbers that turn out to be issues or pull requests are skipped, so GitHub's native issue linking is unaffected, and a pull request whose body references no discussion does nothing at all. Only same-repository references (`#42`) are recognized, not `owner/repo#42`. The action is pinned to `jdx/link-discussion-action@38e7537` — a fork of [`gaojunran/link-discussion-action`](https://github.com/gaojunran/link-discussion-action) v0.1 (MIT) taken at that same commit, so the code that runs against this repository's token is not controlled by a third-party account. The committed `dist/index.js` was verified byte-identical (sha256 `ec31b601…`) to a rebuild from `src/` with the locked dependencies. It authenticates with the automatic `GITHUB_TOKEN` scoped to `discussions: write` and `pull-requests: read`; no new secrets are required. This has been running in [jdx/pitchfork](https://github.com/jdx/pitchfork) since [#596](jdx/pitchfork#596) and is being rolled out to every repository with Discussions enabled. *AI-assisted — Tool: Claude Code; model: anthropic/claude-opus-5; version: 2.1.270.* 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > CI-only automation using scoped GITHUB_TOKEN; no application or runtime behavior changes. > > **Overview** > Adds a **`link-discussion`** GitHub Actions workflow that runs when a pull request is **merged** (not merely closed). It uses the pinned **`jdx/link-discussion-action`** with the default **`GITHUB_TOKEN`**, granted **`discussions: write`** and **`pull-requests: read`**, to find discussion references in the PR body and post a back-link comment (and optionally resolve discussions when keywords like **`Closes #N`** are used). > > This mirrors issue auto-linking for GitHub Discussions so requesters get notified when their feature ships, without adding new secrets. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 95ab9db. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Added automated linking between merged pull requests and related discussions. * Improved visibility and traceability between development changes and community conversations. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This PR contains the following updates:
4.0.4→4.0.5Release Notes
ruby/ruby (ruby)
v4.0.5Compare Source
Configuration
📅 Schedule: (in timezone America/Chicago)
* * * * 5)🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.