Skip to content

Cannot configure HttpClient via HttpClientBuilder #211

Open

Description

@GoogleCodeExporter
What steps will reproduce the problem?
1. Try to configure HttpClient via HttpClientBuilder.
2. Fail because openid4java uses its own HttpClientFactory instead, which calls 
the DefaultHttpClient constructor.

What is expected?
openid4java uses an injectable HttpClientBuilder to construct its HttpClient.

What version of the product are you using? On what operating system?
0.9.8

Please provide any additional information below.
DefaultHttpClient is deprecated and shouldn't be used directly.

Original issue reported on code.google.com by caspar.k...@gmail.com on 17 Jun 2014 at 8:14

Activity

  1. cryptomilk commented on Jan 12, 2017

    @cryptomilk

    This is reason why SNI support with OpenID in Gerrit doesn't work.

    https://bugs.chromium.org/p/gerrit/issues/detail?id=5047

  2. jukedom commented on Jun 6, 2018

    @jukedom

    @cryptomilk exactly, there is an existing fork that supports SNI : #219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions