Repository navigation
Rename FieldDto to BuilderFieldDto - it is builder working state (#372) - #373
Merged
AndreasIgel merged 1 commit intoOct 23, 2026
Conversation
igel-devin-ai
changed the title
FieldDto is used only on the builder definition side and carries the collected builder methods - nothing on the generation side or moving to simple-codegen references it. Renamed instead of split: the field state and method list stay together in one builder-domain type. File moved via git mv to preserve history; all working-side references retyped.
devin-ai-integration
Bot
force-pushed
the
devin/1792788439-builder-field-dto
branch
from
October 23, 2026 21:16
b7beb1c to
3ad68ae
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #372.
Prep for #349:
FieldDtocarriedList<BuilderMethodDto>— builder working state — and review showed it is used only on the builder-definition side: nothing on the generation side consumes it (the render model carriesClassFieldDto) and nothing moving tosimple-codegenreferences it.So instead of splitting the type,
FieldDtois renamed toBuilderFieldDto(file moved viagit mv, history preserved): the field state and the collected builder methods stay together in one honestly-named builder-domain type. In #349 it simply stays processor-side.FieldDto→BuilderFieldDtoacross the builder definition flow:BuilderDefinitionDtofield lists,BuilderDefinitionCreator, theMethodGeneratorSPI (appliesTo/generateMethods), all field generators,GeneratorRegistry, enhancers,MethodGeneratorUtil,BuilderToGenerationTypeMapper(FieldMethod),ClassJavaDocEnhancer.convertToClassField(BuilderFieldDto)stays the working→render field conversion intoClassFieldDto.GetterInfoDto/package-infoand the SPI examples indocs/CUSTOMIZING.md+example-custom-generator/README.mdupdated (also correcting staleProcessingContext→BuilderProcessingContextandMethodDto→BuilderMethodDtothere).528/528 processor tests green; regenerated example output byte-identical.