Bindings generator does not handle multiple derived types

I've noticed when you have several classes based of the same abstract class the codegen can't handle it even thought the syntax looks like it should e.g.

		{
			"Name": "MyNamespace.AbstractShape",
			"BaseTypes": [
				{
					"BaseName": "MyNamespace.BaseSquare",
					"DerivedName": "MyNamespace.Square"
				},
				{
					"BaseName": "MyNamespace.BaseCircle",
					"DerivedName": "MyNamespace.Circle"
				}
			]
		}

Doesn't work

@philipcass

@philipcass Can you please elaborate on what doesn't work?

@jacksondunstan

@jacksondunstan When generating c sharp delegates for each instance of the derived types the code-gen redeclares the common abstract methods multiple times e.g. if GetRadius was declared in AbstractShape it'd create this twice:

		[UnmanagedFunctionPointer(CallingConvention.Cdecl)]
		public delegate double MyNamespaceAbstractShapeGetRadiusDelegateType(int thisHandle);
		public static MyNamespaceAbstractShapeRadiusDelegateType MyNamespaceAbstractShapeGetRadiusDelegateType;

@philipcass

@philipcass Thanks for clarifying. It looks like that code should only be generated for the first derived type, not all of them. I'm not able to address the issue right away, but please do feel free to submit a PR with a fix.

Navigation Menu

Repository navigation

Bindings generator does not handle multiple derived types #68

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Bindings generator does not handle multiple derived types #68

Description

Activity

jacksondunstan commented on Feb 22, 2021

philipcass commented on Feb 22, 2021

jacksondunstan commented on Feb 27, 2021

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions