Skip to content

test(providers): pin posix for bare-name findBinary cases - #234

Merged
j35dev merged 1 commit into
mainfrom
fix/detector-win32-bare-file-tests
Sep 15, 2026
Merged

j35dev merged 1 commit into
mainfrom
fix/detector-win32-bare-file-tests

Conversation

@j35dev

@j35dev j35dev commented Sep 15, 2026 •

Copy link
Copy Markdown
Owner

On Windows, findBinary only accepts .exe/.cmd. Two scan-path tests wrote a bare codex file and inherited process.platform, so they expected a candidate Windows cannot spawn.

Pin platform: 'linux' on those cases, matching the other bare-name tests.

How verified: pnpm verify green (typecheck + lint + tests), including all 21 detector tests on Windows.


Devin Review

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@j35dev
j35dev merged commit f5f7476 into main Sep 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants