Repository navigation
Harden checker scheduling, state ordering, workflows, and dashboard - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An API request that rescheduled a checker could cancel after success and permanently stop that checker's timer. Two replicas sharing a checker name could also let an earlier-started check finish late and overwrite a newer result. This PR keeps timer lifetime with the scheduler and host, and prevents stale results from rewinding persisted health state.
The same change set addresses the related audit findings:
The timer, state-ordering, read-amplification, constructor, telemetry, and dashboard regressions were observed before their fixes. A Release solution build passed with zero warnings. Direct xUnit runners on both .NET 8 and .NET 10 passed 637 unit tests each (590 passed, 47 Docker-backed tests skipped); the browser E2E suite passed 54/54. A local dashboard sweep at 375, 768, 1280, and 1920 px, plus throttled mobile, showed no overflow or console errors, and keyboard activation of a checker worked. Workflow YAML parsed successfully. The machine has SDK 10.0.400 while
global.jsonrequires 10.0.401, so the standarddotnet testcommand could not run; the built xUnit executables were used instead.This PR does not publish a package or deploy production. The separate landing hardening is in ivanvyd/landings#22; its visible version remains 4.1.3, the latest published release.