Repository navigation
Harden scheduling failover and state recording - #74
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow or partial leader reconciliation could outlive its lease, stale durable schedules could survive failover, and several state mutations could overwrite concurrent updates. This change keeps lease renewal independent from bounded scheduler reconciliation, tracks partial work until cleanup succeeds, reconciles current persisted checker state in bulk, and makes history and uptime updates concurrency-safe.
It also validates scheduler-specific limits before replacing working schedules, preserves Healthie's leading-seconds cron meaning in Temporal, rejects Cronos extensions whose Temporal semantics differ, and uses Cosmos DB
ReadManyItemsAsyncfor multi-state reads.Validation:
dotnet restore Healthie.NET.sln --locked-modedotnet build Healthie.NET.sln --configuration Release --no-restore— 0 warnings, 0 errorsdotnet test tests/Healthie.Tests.Unit/Healthie.Tests.Unit.csproj --configuration Release --no-restore— 617 passed onnet8.0; 617 passed onnet10.0dotnet list Healthie.NET.sln package --vulnerable --include-transitive— no vulnerable packagesNo live Cosmos DB, Temporal, Hangfire, or Coravel backend was required for these unit-level paths; their request construction, parser behavior, concurrency boundaries, and failure handling are covered with deterministic tests and fakes.