Name the story that owns the declared script-audit gap - #45
Merged
Conversation
The declared gap for script-command audit warning classes named STORY-260822-27ze8z, which scopes manifest module-roots parsing and carries no audit-label surface -- and which closes with the task that added this consumer. The surface is owned by STORY-260822-2evh3p, whose scope explicitly includes declared-only audit labeling for legacy schemas. The reason strings were the one classification in this mechanism no test read, so a gap could rot into an orphan silently. The section classification test now also asserts that every declared gap names an owning story, and the case-ledger row says so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework from the TASK-260824-31y75t review verdict, item 1.
tests/test_schema8_candidate_conformance.pydeclared the missingscript-command audit warning classes as owned by
STORY-260822-27ze8z(
module-roots-implementation). That story scopes manifest module-rootsparsing, bijection validation, containment and diagnostics — it has no
audit-label surface — and it closes with the task that added this consumer.
The real owner is
STORY-260822-2evh3p(script-worker-v1-implementation),whose scope explicitly includes declared-only audit labeling for legacy schemas.
The classification reason strings were the one part of this mechanism no test
read:
test_script_policy_sections_are_all_classifiedchecked the section keyset in both directions but never the reasons, so a gap could rot into an orphan
without a lane noticing. That test now also asserts every declared gap names an
owning story, and the
candidate-cases.tsvrow for it says so.Verification
Run against the exact candidate identity this task qualifies —
6001dc33281b94a4ec7442ab15278550dd0f51d9, manifest sha256803918bf8672f76cf990985e51db213b826674cd5bb54fbf47731b8404b44403.CSK_REQUIRE_FULL_CANDIDATE_ROOT=1)candidate_consumption.py requirecandidate_consumption.py gate --platform darwinpython -m mypyactionlinttests/test_candidate_consumption.py+tests/test_ci_workflow.pyNegative controls, all red, rebuilt from the real candidate root on this tree:
requiregatePlus one control for the new assertion: stripping the owner from the declared
gap fails
test_script_policy_sections_are_all_classifiedby name (exit 1).