Repository navigation
Fix optional union types in generated Python signatures - #7600
Open
huxiaoyi-ovo wants to merge 3 commits into
Open
huxiaoyi-ovo wants to merge 3 commits into
huxiaoyi-ovo wants to merge 3 commits into
Conversation
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix generated Python signatures for optional pybind11 arguments that use PEP 604 union syntax such as
T | None.Open3D's docstring parser did not allow
|in argument types, so signatures emitted by pybind11 3 could be truncated before stub generation. Forcompute_fpfh_feature, this made the optionalindicesargument appear required in the generated type stub.This change:
|in parsed argument type expressions;compute_fpfh_feature(..., indices=None)signature.Fixes #7583.
Validation
The branch was validated against Open3D's CI before submission:
One fork CI job reported failure only in the final wheel artifact upload step after build/tests succeeded: the workflow searches for
open3d-[0-9]*.whl, while the produced wheel is namedopen3d_cpu-*.whl. No code or test step failed.