Repository navigation
Adding "how to create new page" to CONTRIBUTING.md - #1294
Conversation
|
@johnnymatthews @ElPaisano I may still want to add more screenshots or go into more detail about certain things. Let me know what you think. |
|
@TMoMoreau made some general comments above, might be easier to just talk through them real quick |
ElPaisano
left a comment
There was a problem hiding this comment.
Made a first pass, I can take another look in a bit or after you push this - I don't want to be a blocker to getting it to prod
|
General comment: The score is a function of:
I ran markdownlint which, among other things, checks if line length is greater than 80. (this is configurable). I saw a lot of output like: So, just something to keep in mind. If possible, keep sentences as short as possible, as it will make the overall reading experience easier for most readers. This will also bring the readability score up. |
|
markdown-link-check came back clean 💯 |
|
Noticed a few other errors that aren't in this PR scope but are in CONTRIBUTING.md. Might be good to fix these here. Line 79: "There're". This should be "There are" |
Fixed this because it's weird. I do want it to be known though, that this is technically a grammatically correct contraction. |
johnnymatthews
left a comment
There was a problem hiding this comment.
Made a couple of suggestions, but looks great apart from those!
|
Glanced over it, looks solid to me 👍 |
salmad3
left a comment
There was a problem hiding this comment.
Nice @TMoMoreau! Added suggestions.
johnnymatthews
left a comment
There was a problem hiding this comment.
Looks good! Let's get this merged.
|
|
Looks like I need @DannyS03 to approve as well to get the "changes requested" thing green. |
This PR is in reference to issue #1264