[C API] Move C API samples to the examples directory - #367
Merged
Conversation
rfsaliev
marked this pull request as ready for review
August 19, 2026 15:04
rfsaliev
requested review from
ahuber21,
ethanglaser and
ibhati
as code owners
August 19, 2026 15:05
rfsaliev
added a commit
that referenced
this pull request
Aug 24, 2026
**Important note:** > **This API refactoring breaks compatibility with existing client code** Refactor API for better consitency, stability, extensibility. - Updated ThreadPoolBuilder to ensure custom threadpool pointers are validated and initialized correctly. - Enhanced error handling in parallel_for method to catch exceptions and rethrow them appropriately. - Modified IDFilterAdapter to check for null operations and validate filter rates during initialization. - Adjusted test cases to reflect changes in function signatures and ensure proper error handling. - Introduced new utility functions for initializing search results and memory breakdown structures. - Updated sequential threadpool implementation to return a boolean indicating success - All public headers moved to `include/svs/c/`, and installation paths updated to match, replacing the old `c_api` directory. - Added generated version header `svs_c_version.h` with version macros, configured and installed via CMake. - Refactored `svs_search_result_t` structure now allows user to pre-allocate result buffers. - Added a detailed `README.md` for the C API, including build instructions, usage, and sample code. - Moved C API samples to the examples directory (#367) - Addressed API contract issues and resolve implementation bugs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.