skip LVQ/LeanVec examples in public-only integration tests - #314
Closed
yuejiaointel wants to merge 1 commit into
Closed
skip LVQ/LeanVec examples in public-only integration tests#314yuejiaointel wants to merge 1 commit into
yuejiaointel wants to merge 1 commit into
Conversation
The public-only and IVF builds don't include LVQ/LeanVec support, so the FAISS LVQ/LeanVec examples crash with "storage kind not compatible". Skip them based on SUFFIX.
yuejiaointel
requested review from
ethanglaser,
homksei and
mihaic
as code owners
April 7, 2026 20:02
mihaic
approved these changes
Apr 7, 2026
Contributor
Author
|
seems like a sporadic issue, no need to fix |
Member
|
To clarify - this does need to be fixed, but because a rerun usually resolves it hasn't been addressed as urgently. But the solution is not to skip the runs - we should be supporting clean fallback on non-Intel hardware and that's what these tests are validating |
ahuber21
added a commit
that referenced
this pull request
Aug 25, 2026
The faiss LVQ/LeanVec tutorials carry no capability gate, so they only run successfully with an LVQ/LeanVec-enabled runtime on Intel hardware. test-faiss.sh inferred that from the CPU vendor alone, which is wrong for the public-only build: the formats are compiled out there, so the examples abort on every runner and that leg was green only when GitHub allocated a non-Intel one. Derive the expectation from ENABLE_LVQ_LEANVEC as well, plumbed into the test job from the same value the artifact was built with, and name the actual reason in the log. The examples still run in that case and must still fail, but now they have to fail with the runtime's storage-kind rejection: a bare nonzero exit also covers a missing library or a segfault, which is not what is under test. Supersedes #314, which keyed off the -public-only artifact name. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary