refactor: migrate resource_github_issue_label to context-aware CRUD a…

[slymanmrcan]

Addresses parts of #3070
Addresses parts of #2996

---

Before the change?

• resource_github_issue_label uses legacy Create/Read/Update/Delete
  schema functions and log.Printf for logging.

After the change?

• Migrated to CreateContext/ReadContext/UpdateContext/DeleteContext
• Function signatures updated to (ctx context.Context, d *schema.ResourceData, meta any) diag.Diagnostics
• Replaced log.Printf with tflog.Info for structured logging
• Removed manual context.Background() calls
• Wrapped error returns with diag.FromErr()

Pull request checklist

• Schema migrations have been created if needed — N/A, no schema change
• Tests for the changes have been added — N/A, no behavior change
• Docs have been reviewed and added / updated if needed — N/A

Does this introduce a breaking change?

• No

[github-actions]

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

[deiga]

Please remove the resolves comment, since it adresses the issue only partly. And "resolves" will close the issue

[deiga]

LGTM!

Thanks for the contribution!

[slymanmrcan]

I just removed it from the description

[deiga]

Would you be available to rebase this (possibly multiple times) during the next week? We're going to release 6.13.0 and will try to land some of these open PRs

[Copilot]

Pull request overview

This PR refactors resource_github_issue_label to use Terraform Plugin SDK v2 context-aware CRUD function signatures and structured logging via tflog, aligning the resource with ongoing provider-wide migrations tracked in #2996 and #3070.

Changes:

• Migrated the resource from legacy Create/Read/Update/Delete to CreateContext/ReadContext/UpdateContext/DeleteContext.
• Updated CRUD implementations to return diag.Diagnostics and wrap errors with diag.FromErr.
• Replaced log.Printf usage with tflog.Info structured logging and removed context.Background() usage.

[slymanmrcan]

Yes, I can rebase it during the next week as needed.

I’ll rebase now and address the Copilot review comments as well.

[deiga]

@stevehipwell even though there are other parts here that could be refactored, I would suggest we do the minimum here to get this merged.

[stevehipwell]

For me the bare minimum here would be to separate create & update and remove the call to read from them.

[slymanmrcan]

Thanks, I separated the create and update handlers and removed the explicit read call from both paths while keeping the existing idempotent create behavior for default GitHub labels.

[stevehipwell]

@slymanmrcan this is looking good. There are still a couple of outstanding comments to address and it looks like you haven't run the strict linting for new code?

[slymanmrcan]

Thanks, my mistake. I missed the strict new-code lint locally.
I’ve run it now and addressed the findings in the latest push.

[slymanmrcan]

Thanks for the review! I’ve pushed the fixes now: color/description are set from Read again, and Create preserves the previous GetLabel-then-EditLabel behavior for existing labels.

[deiga]

@slymanmrcan could you please rebase the branch?

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[stevehipwell]

As per my previous comment, this resource should fail on create if the label already exists. You can either import or use github_isue_labels to handle the existing label scenario.

[slymanmrcan]

thanks for review
@stevehipwell @deiga

• removed GetLabel/EditLabel adopt logic from create, now fails if label already exists
• fixed description to use d.Get instead of d.GetOk to allow clearing it

[stevehipwell]

@slymanmrcan could you please fix the lint failures?

[slymanmrcan]

Thanks, fixing it now.

[stevehipwell]

@slymanmrcan you appear to have been caught out by a regression.

@deiga any thoughts?

[stevehipwell]

LGTM

[robert-crandall]

Thanks for this! The migration to context-aware CRUD with diag and tflog is clean and consistent, and I really appreciate how quickly you turned around the feedback. The color/description read-back restores drift detection, and setting the description unconditionally so it can be cleared is exactly right. Nice, well-scoped change. 🙏