You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There was no real reason to branch till now and nobody ever questioned it. I see a basic pro/cons situation:
If we branch we have to push the changes to multiple branches everytime. (e.g. update the CI, documentation of a new feature). dob can work down to Odoo version 8 (replace doblib with doblib-legacy in the dependencies if you want to go below 11.0).
If we keep everything in one branch you might have to adjust the odoo:version, maybe the python requirements and if you want to go pack further in the odoo versions the python version. These things we normally have to check for new projects anyways. The biggest pain is always the python packages and versions because we have to freeze and pin older packages for older versions. For a testing it's often enough to change only the odoo:version and the branches would have minimal changes.
Our current premise is:
This is a template repository
For demo purposes it's configured for the latest Odoo versions
Ok, I understand your point. What about tagging the latest commit where dob was based on the previous Odoo version.
So when you need a specific odoo version you can simply checkout the tagged commit.
We have documented the features in the docs folder but the features are implemented within the python package dob-lib (version independent like debugger setup etc.). If we use tags the features are available but not documented. It would be worse than using branches for me because people would ask for documented features because they use old commits which only lack the documentation.
Maybe we can think about storing some patches within the repo to get to the different versions more easily. Not sure how we would handle the versions of the python packages.
Ok thank you for your response. Anyway, it would be great if we could get a previous version of Odoo in a quick way. But doesn't matter. If you have got a suitable solution, feel free to make a short update here. Thank you for developing dob an making it Open Source.
Activity
fkantelberg commentedon Mar 1, 2024
There was no real reason to branch till now and nobody ever questioned it. I see a basic pro/cons situation:
If we branch we have to push the changes to multiple branches everytime. (e.g. update the CI, documentation of a new feature). dob can work down to Odoo version 8 (replace doblib with doblib-legacy in the dependencies if you want to go below 11.0).
If we keep everything in one branch you might have to adjust the
odoo:version, maybe the python requirements and if you want to go pack further in the odoo versions the python version. These things we normally have to check for new projects anyways. The biggest pain is always the python packages and versions because we have to freeze and pin older packages for older versions. For a testing it's often enough to change only theodoo:versionand the branches would have minimal changes.Our current premise is:
wildi1 commentedon Mar 6, 2024
Ok, I understand your point. What about tagging the latest commit where dob was based on the previous Odoo version.
So when you need a specific odoo version you can simply checkout the tagged commit.
fkantelberg commentedon Mar 6, 2024
We have documented the features in the docs folder but the features are implemented within the python package
dob-lib(version independent like debugger setup etc.). If we use tags the features are available but not documented. It would be worse than using branches for me because people would ask for documented features because they use old commits which only lack the documentation.Maybe we can think about storing some patches within the repo to get to the different versions more easily. Not sure how we would handle the versions of the python packages.
wildi1 commentedon Mar 6, 2024
Ok thank you for your response. Anyway, it would be great if we could get a previous version of Odoo in a quick way. But doesn't matter. If you have got a suitable solution, feel free to make a short update here. Thank you for developing dob an making it Open Source.
wildi1 commentedon Mar 15, 2024
What is about placing different Dockerfiles in the repo: