Repository navigation
Conversation
added 3 commits
September 25, 2023 17:32
Author
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
resolves #255 The underlying issue was that the reference to wrap was removed just after the constructor was called. The code was there probably due to a workaround bug in the previous version of node. May need to clean up reference to wrap when finalizer is invoked
|
Build failed: |
Author
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
resolves #255 The underlying issue was that the reference to wrap was removed just after the constructor was called. The code was there probably due to a workaround bug in the previous version of node. May need to clean up reference to wrap when finalizer is invoked
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #255
The underlying issue was that the reference to wrap was removed just after the constructor was called. The code was there probably due to a workaround bug in the previous version of node.
May need to clean up reference to wrap when finalizer is invoked