Repository navigation
Fix clippy assert_is_empty failures on Rust 1.99 - #7
Merged
Merged
Conversation
Newer stable clippy flags assert!(x.is_empty()) in tests. Use assert_eq!/assert_ne! so failures show the value, which restores the Checks workflow. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RjtG21XFk7KzzvtNSYt1vf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_is_emptylint, which broke theChecksworkflow's lint step onmain.assert!(x.is_empty())becomeassert_eq!(x.len(), 0)(andassert_ne!for the negated form), so failures still show the value. Tests only; no behaviour change.Testing
On Rust 1.99.1 locally:
scripts/check-spec.sh,cargo fmt --all --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspace(474 passed, 0 failed).Generated by Claude Code