Skip to content

event/bus: add specialActive event to workspace#14971

Merged
vaxerski merged 1 commit into
hyprwm:mainfrom
vaxerski:special-active-event
Jun 5, 2026
Merged

event/bus: add specialActive event to workspace#14971
vaxerski merged 1 commit into
hyprwm:mainfrom
vaxerski:special-active-event

Conversation

@vaxerski

@vaxerski vaxerski commented Jun 4, 2026

Copy link
Copy Markdown
Member

allows for special workspace state tracking

allows for special workspace state tracking
@MicaelLoberg

Copy link
Copy Markdown

I have a PR that does something very similar
#14802

Difference is that I have 2 events, one for special opened and one for closed so I don't have to do null checks in lua to figure out what is happening

@vaxerski

vaxerski commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

I believe this one makes more sense, it relays precisely what happened.

I don't see the problem in doing if ws ~= nil

@Dregu

Dregu commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

At least this is more versatile than simply extending workspace.active to cover specials and that wouldn't have even made sense if get_active_workspace doesn't even return specials.

Doesn't really answer which special workspace was closed though. I don't know if that is useful information.

@vaxerski

vaxerski commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

it does, because it still has the monitor param. If you keep track of what is open where, you can know what closed.

@Dregu

Dregu commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Yeah well having to keep track of it yourself is like the opposite of what I meant. But at least it's not hard and like I said might not even be useful.

@vaxerski
vaxerski merged commit ef9b623 into hyprwm:main Jun 5, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants