view: consolidate group flags and apply window rules

[kaosuran]

Hi,
noticed a regression since the Groups refactor (#13460), after some poking I think I've finally found the solution, albeit I'm not sure if I'm doing it properly, sorry, I'm new to this codebase!

I've built it and tested it locally and it seemingly works, the group rules are being applied again.

As now the code's using bitmasks and a flags holder, the m_locked and m_deny became redundant (I've tried setting them with the bitmasks, but that wouldn't work for some reason..?).

Wasn't able to test it properly with hyprtester unfortunately, had some luck running it using Xephyr, but it'd fail on tests that'd assume I have kitty terminal emulator installed etc., not sure how to run it properly, wouldn't work from a fresh TTY either.. but ctest passed.

[github-actions]

Hello and thank you for making a PR to Hyprland!

Please check the PR Guidelines and make sure your PR follows them.
It will make the entire review process faster. :)

If your code can be tested, please always add tests. See more here.

beep boop, I'm just a bot. A real human will review your PR soon.

[vaxerski]

can you please write some tests for this? :)

[kaosuran]

can you please write some tests for this? :)

I will try later, but I can't promise anything, hyprtester isn't working right for me :/ will try running it under a VM, maybe it'll stop crashing like crazy.

[kaosuran]

can you please write some tests for this? :)

Hello again, sorry it took so long, I've added 3 tests:

1. Check behavior for regular groups, make sure they merge normally
2. Check behavior for locked groups, make sure they don't merge
3. Check behavior for locked groups with invade rule, make sure they do merge

Testing locally I got:

Passed: Tests::windowCount(). Got 0
Passed: getFromSocket("/dispatch togglegroup"). Got ok
Passed: str contains "at: 22,22" 2 times.
Passed: Tests::windowCount(). Got 0
Passed: getFromSocket("/dispatch togglegroup"). Got ok
Passed: getFromSocket(std::format("/dispatch focuswindow pid:{}", lockedWin->pid())). Got ok
Passed: getFromSocket("/dispatch lockactivegroup lock"). Got ok
Passed: str contains "at: 22,22" 1 times.
Passed: Tests::windowCount(). Got 0
Passed: getFromSocket("/keyword windowrule[locked-im]:match:class ^locked|invade$"). Got ok
Passed: getFromSocket("/keyword windowrule[locked-im]:group set always lock invade"). Got ok
Passed: str contains "at: 22,22" 2 times.
Passed: Tests::windowCount(). Got 0

The clang CI seemingly fails due to the main upstream changes 🙏🏻
Please let me know if there's something else I should do, thanks for your time!

[vaxerski]

lgtv