dekstop/window: read static rules before guessing initial size if possible

[vaxerski]

Ref #12753

[C0Florent]

did you fix something else in your force push?
I started to build at d551986, i'm just curious if i should restart with your latest commit or if it's the same thing

[vaxerski]

no I just rebased

[fxzzi]

rename dialog in thunar now opens the correct size

[C0Florent]

I must be doing something wrong, as soon as I press any of my binds to open an app (even those which i don't open floating) hyprland crashes (segv) and I get sent into safe mode.
in safe mode I can use binds to open windows, no problem, I can load my config and everything is fine but if then i press a bind to open anything it crashes again
might be related to something else on main, i was using 0.53 before

from the safe mode environment it seems like when i have a bind to exec, [float] $terminal, it doesn't open floating. could be something the default config, or a bug idk. If i force it to open floating with a windowrule however it does open with the right size, so I guess the fix is working (?)

[vaxerski]

mamma mia you are correct

[vaxerski]

couldnt repro the crash tho

[C0Florent]

I'll try to rebuild with this, just as additional info, it must be my config running some specific codepaths because i was crashing when any windows were getting opened, no matter if it was by exec-once or by running something from a terminal (the terminal being opened in safe mode then loading my config before trying to open something else)

[vaxerski]

gdb stacktrace pls

[C0Florent]

gdb stacktrace pls

I'm happy to see there's a hyprland-debug nix package, I should be able to get a trace quicker than I anticipated thanks to the awesome wiki

[C0Florent]

ah, actually nix build fails on this PR so that doesn't help immediately

[vaxerski]

I can see the tester in CI is dying too but I cant repro here lole

[C0Florent]

i'm getting this, seems to be simple to fix? i know basically nothing about cmake though

CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  Cannot find source file:

    clients/pointer-warp.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
  .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
  .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:101 (clientNew)


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  Cannot find source file:

    clients/pointer-scroll.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
  .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
  .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:102 (clientNew)


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  Cannot find source file:

    clients/child-window.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
  .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
  .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:103 (clientNew)


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  Cannot find source file:

    clients/shortcut-inhibitor.cpp

  Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm
  .ccm .cxxm .c++m .h .hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90
  .f95 .f03 .hip .ispc
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:104 (clientNew)


CMake Error at CMakeLists.txt:636 (add_executable):
  No SOURCES given to target: hyprland_gtests
  

CMake Error at hyprtester/CMakeLists.txt:16 (add_executable):
  No SOURCES given to target: hyprtester


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  No SOURCES given to target: pointer-warp
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:101 (clientNew)


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  No SOURCES given to target: pointer-scroll
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:102 (clientNew)


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  No SOURCES given to target: child-window
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:103 (clientNew)


CMake Error at hyprtester/CMakeLists.txt:84 (add_executable):
  No SOURCES given to target: shortcut-inhibitor
Call Stack (most recent call first):
  hyprtester/CMakeLists.txt:104 (clientNew)


CMake Generate step failed.  Build files cannot be regenerated correctly.

[C0Florent]

Anyways, this is getting too far into 2026 for tonight (2am), so i'll try to get a proper debug build tomorrow
for some reason I can't get a debug build from the hyprland flake, it seems to be failing to build hyprtester, but building non-debug works fine. ig could try a manual build from a fresh clone to only get a hyprland build in debug mode without building hyprtester if that's the only problem.

[vaxerski]

I'm leaving for a new years get together soon too so I will check this out tomorrow if I am not too drunk from water and coca cola

[C0Florent]

gdb stacktrace obtained
gdb.txt

[C0Florent]

looks like a tasty nullptr member access

#6  0x0000555c7c627df2 in CWorkspace::matchesStaticSelector (this=0x0, selector_=...)

[C0Florent]

This fixes it for me

diff --git a/src/desktop/rule/windowRule/WindowRule.cpp b/src/desktop/rule/windowRule/WindowRule.cpp
index d1994d2e..546680c1 100644
--- a/src/desktop/rule/windowRule/WindowRule.cpp
+++ b/src/desktop/rule/windowRule/WindowRule.cpp
@@ -93,6 +93,8 @@ bool CWindowRule::matches(PHLWINDOW w, bool allowEnvLookup) {
                     return false;
                 break;
             case RULE_PROP_ON_WORKSPACE:
+                if (!w->m_workspace)
+                    continue;
                 if (!engine->match(w->m_workspace))
                     return false;
                 break;

to my understanding it was trying to check for match:workspace props before the window was assigned a workspace, so I just skipped the check. might make more sense to try and assign a workspace before the check instead, but no idea how that would be done.

also needed this to be able to build the hyprland-debug flake output, it was trying to build hyprtester but the tests' source weren't being copied to the build directory

diff --git a/nix/overlays.nix b/nix/overlays.nix
index fdb3e652..8e947796 100644
--- a/nix/overlays.nix
+++ b/nix/overlays.nix
@@ -86,7 +86,7 @@ in {
     (final: prev: {
       aquamarine = prev.aquamarine.override {debug = true;};
       hyprutils = prev.hyprutils.override {debug = true;};
-      hyprland-debug = prev.hyprland.override {debug = true;};
+      hyprland-debug = prev.hyprland.override {debug = true; withTests = true;};
     })
   ];

once again might not be the best way to fix this, i just went with the first thing that got it to build

[vaxerski]

tha ks

[vaxerski]

@fufexan can you >> this into kitty.conf in the VM?

remember_window_size no
initial_window_width  640
initial_window_height 400

[vaxerski]

@fxzzi @C0Florent is this fixed for you?

[fxzzi]

yes