Removes requirement of specific environment variables during testing - #108
Merged
Conversation
ludfjig
force-pushed
the
remove_env_test
branch
from
December 12, 2024 18:08
b47f23c to
f35af55
Compare
ludfjig
added
the
kind/enhancement
ludfjig
marked this pull request as ready for review
December 12, 2024 18:24
simongdavies
requested changes
Dec 12, 2024
ludfjig
force-pushed
the
remove_env_test
branch
from
December 13, 2024 18:09
f35af55 to
e8ba7d7
Compare
simongdavies
approved these changes
Dec 16, 2024
ludfjig
force-pushed
the
remove_env_test
branch
from
December 20, 2024 19:48
e8ba7d7 to
eb3b07c
Compare
simongdavies
previously approved these changes
Jan 16, 2025
Member
|
@ludfjig once this merges we should update the common workflow setup to get rid of the variables there too |
dblnz
previously approved these changes
Jan 20, 2025
ludfjig
force-pushed
the
remove_env_test
branch
from
January 23, 2025 00:56
eb3b07c to
52f3bc7
Compare
Contributor
Author
|
ludfjig
force-pushed
the
remove_env_test
branch
2 times, most recently
from
January 23, 2025 23:03
30893ab to
b59e40d
Compare
…g tests. Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
ludfjig
force-pushed
the
remove_env_test
branch
from
January 28, 2025 17:54
b59e40d to
abc98ea
Compare
syntactically
approved these changes
Jan 28, 2025
marosset
approved these changes
Jan 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These environment
KVM_SHOULD_BE_PRESENTHYPERV_SHOULD_BE_PRESENTvariables just add unnecessary complexity, especially for newcomers who just cloned the repo. They're not very useful anyway