188 stack transformer blocks - #216
Merged
Merged
Conversation
added 17 commits
May 23, 2025 00:02
- Fix tensor reshaping logic in QKV projection\n- Maintain proper int8 type consistency throughout\n- Improve tensor data copying efficiency\n- Fix invalid shape dimension error
- Update attention and FFN layer implementations\n- Add test data for model validation\n- Modify tensor operations and model tests\n- Update BitNet-related scripts
Replace direct logging with structured logging using loggers package for better debugging and consistency
- Replace direct fmt/os usage with loggers package\n- Remove unused ErrInvalidHeadDimension error
- Add specific error types for attention and tensor operations\n- Replace generic error wrapping with typed errors\n- Add debug logging before error returns\n- Remove unused fmt import
thejhh
marked this pull request as ready for review
May 23, 2025 12:09
added 7 commits
May 23, 2025 15:27
added 19 commits
May 23, 2025 19:47
- Improve attention output computation efficiency\n- Enhance FFN sublayer performance\n- Update model tests for optimized operations\n- Refine sublayer normalization implementation
…real math in Infer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Test Coverage
Areas for Improvement
High Priority
Medium Priority
Low Priority
Implementation Details
Closes #188