feat(bitnet/model): implement model weights and tokenizer integration - #197
Conversation
… with tests and benchmarks (issue #172)
thejhh
left a comment
There was a problem hiding this comment.
Fix review comments
…management -- use absolute paths, fix chunk pool, improve loader tests and error handling
… -- loads from correct path, covers unknown words, decoding, special tokens, removes BPE fallback for unknown words
…net/model -- all logic now lives in internal/model
thejhh
left a comment
There was a problem hiding this comment.
We need to make changes I've described in the full review comments.
…fs dependency, unified model/tokenizer loading, test/bench isolation)
thejhh
left a comment
There was a problem hiding this comment.
Error handling requires some work still. See full review comments.
|
We need to test all code: |
|
Some tests are also failing: |
|
This is failing too: |
thejhh
left a comment
There was a problem hiding this comment.
Still some review comments unresolved.
Also fix missing tests:
? github.com/hyperifyio/gnd/pkg/bitnet/internal/config [no test files]
? github.com/hyperifyio/gnd/pkg/bitnet/internal/math [no test files]
There was a problem hiding this comment.
Pull Request Overview
This PR restructures and enhances the BitNet project’s .cursor/rules documentation by removing outdated guidelines, adding new standardized procedures, and expanding workflow and benchmark guidance.
- Removed deprecated rule files.
- Introduced new PR update, review, and creation templates.
- Updated project overview, environment setup, branching strategy, and benchmarking guidelines.
Reviewed Changes
Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.cursor/rules/bitnet-pr-update-procedures.mdc |
New standardized PR update procedures |
.cursor/rules/bitnet-pr-review-workflow.mdc |
Added PR review workflow guidelines |
.cursor/rules/bitnet-pr-creation-description.mdc |
Added PR creation & description format template |
.cursor/rules/bitnet-overview.mdc |
Updated high-level project overview and goals |
.cursor/rules/bitnet-environment.mdc |
Updated development environment setup instructions |
.cursor/rules/bitnet-branching-strategy.mdc |
Defined branch creation and naming conventions |
.cursor/rules/bitnet-benchmarks.mdc |
Defined benchmark file placement and naming rules |
.cursor/rules/bitnet-benchmark-invocation.mdc |
Added benchmark invocation and profiling commands |
.cursor/rules/bitnet-benchmark-categories.mdc |
Introduced benchmark semantic categories |
.cursor/rules/bitnet-benchmark-analysis.mdc |
Added guidance for interpreting and tracking results |
Comments suppressed due to low confidence (8)
thejhh
left a comment
There was a problem hiding this comment.
We still have broken tests:
--- FAIL: TestTokenize (0.00s)
--- PASS: TestTokenize/known_words (0.00s)
--- FAIL: TestTokenize/unknown_word (0.00s)
--- PASS: TestTokenize/empty_text (0.00s)
We also are missing tests for pkg/bitnet/internal/math/ops.go and pkg/bitnet/internal/config/config.go.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
thejhh
left a comment
There was a problem hiding this comment.
Ok , finally we can move on :)
Changes
Test Coverage
Performance Metrics
Memory Usage
CPU Performance
Areas for Improvement
High Priority
Medium Priority
Low Priority