Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Adapt to new OCI spec for root - #197

Merged
laijs merged 1 commit into
hyperhq:masterfrom
WeiZhang555:fix-runv-containerd
Apr 26, 2016
Merged

Adapt to new OCI spec for root#197
laijs merged 1 commit into
hyperhq:masterfrom
WeiZhang555:fix-runv-containerd

Conversation

@WeiZhang555

Copy link
Copy Markdown
Contributor

Now docker use absolute bundle root path instead of relative
[$BUNDLE]/rootfs path, and OCI has made relative changes.

Change runv-containerd to adapt this change, or it won't work any more.

See moby/moby#22256 and opencontainers/runtime-spec#394

Signed-off-by: Zhang Wei zhangwei555@huawei.com

@laijs

laijs commented Apr 26, 2016

Copy link
Copy Markdown
Contributor

could you check whether it is absolute path or not at first.
for relative root path, we need to join it to the bundle path.

@WeiZhang555

Copy link
Copy Markdown
Contributor Author

Yep, you are right. My fault.

@WeiZhang555
WeiZhang555 force-pushed the fix-runv-containerd branch from 3de83a7 to 1adb90a Compare April 26, 2016 09:50
@WeiZhang555

Copy link
Copy Markdown
Contributor Author

updated.

Now docker use absolute bundle root path instead of relative
[$BUNDLE]/rootfs path, and OCI has made relative changes.

Change runv-containerd to adapt this change, or it won't work any more

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
@WeiZhang555
WeiZhang555 force-pushed the fix-runv-containerd branch from 1adb90a to ef286d7 Compare April 26, 2016 11:21
@laijs
laijs merged commit 1fad303 into hyperhq:master Apr 26, 2016
@WeiZhang555
WeiZhang555 deleted the fix-runv-containerd branch May 3, 2016 14:27
@gnawux gnawux modified the milestone: v0.6.0 May 25, 2016
harche pushed a commit to harche/runv that referenced this pull request Nov 28, 2017
realloc read buffer for control channel
jimoosciuc pushed a commit to jimoosciuc/runv that referenced this pull request May 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants