Skip to content

[WIP] ESM-2 Attention interface refactor - #40211

Closed
pstjohn wants to merge 3 commits into
huggingface:mainfrom
pstjohn:pstjohn/esm2-attn-interface
Closed

pstjohn wants to merge 3 commits into
huggingface:mainfrom
pstjohn:pstjohn/esm2-attn-interface

Conversation

@pstjohn

@pstjohn pstjohn commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Refectors the ESM-2 model to use the new ATTENTION_INTERFACE api.

Some of the unit tests are still failing, need to debug.

Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
@github-actions

Copy link
Copy Markdown
Contributor

[For maintainers] Suggested jobs to run (before merge)

run-slow: esm

@vasqu vasqu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fyi, you can take a look at #38301 for a refactor there. This is similar to Bert at first glance

@pstjohn

pstjohn commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

closing in favor of #40370, thanks!!

@pstjohn pstjohn closed this Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants