Repository navigation
Add ImageProcessorFast to BiT processor - #37180
Merged
Merged
Conversation
72 of 81 tasks
Yann-CV
marked this pull request as ready for review
April 2, 2025 07:57
Contributor
Author
|
do not know why test are taking forever |
Member
|
@Yann-CV try rebasing to trigger the tests if they don't start automatically once you mark it ready for review! |
Contributor
Author
|
worked thanks @Rocketknight1 |
Contributor
Author
|
@ydshieh @yonigozlan this one looks ready to be reviewed |
yonigozlan
reviewed
Apr 2, 2025
yonigozlan
left a comment
Contributor
There was a problem hiding this comment.
Looks great @Yann-CV thanks for contributing, and thanks for adding tests! a few things to remove then LGTM
Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
Contributor
Author
|
@yonigozlan should be good now |
yonigozlan
approved these changes
Apr 7, 2025
yonigozlan
left a comment
Contributor
There was a problem hiding this comment.
Perfect! Thanks for iterating 馃.
Let's wait for @ArthurZucker final approval before merging
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
cyr0930
pushed a commit
to cyr0930/transformers
that referenced
this pull request
Apr 18, 2025
* Add ImageProcessorFast to BiT processor * propose a fast processor and add tests * all tests pass except one * run make * remove useless print * use same test as clip * apply make * Update src/transformers/models/bit/image_processing_bit_fast.py Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> * Update setup.py Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> * Update src/transformers/models/bit/image_processing_bit_fast.py Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> * apply review comment --------- Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
zucchini-nlp
pushed a commit
to zucchini-nlp/transformers
that referenced
this pull request
May 14, 2025
* Add ImageProcessorFast to BiT processor * propose a fast processor and add tests * all tests pass except one * run make * remove useless print * use same test as clip * apply make * Update src/transformers/models/bit/image_processing_bit_fast.py Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> * Update setup.py Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> * Update src/transformers/models/bit/image_processing_bit_fast.py Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com> * apply review comment --------- Co-authored-by: Yoni Gozlan <74535834+yonigozlan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following #36978:
This pull request introduces a new fast image processor class for the BiT model along with the necessary updates to integrate it into the existing codebase. The most important changes include the addition of the
BitImageProcessorFastclass, modifications to the initialization and import structures, and updates to the documentation and tests.New Feature Addition:
src/transformers/models/bit/image_processing_bit_fast.py: Added the newBitImageProcessorFastclass, which includes methods for preprocessing images with various settings and parameters.Integration Updates:
src/transformers/__init__.py: Updated the import structure to includeBitImageProcessorFastin themodels.bitmodule. [1] [2]src/transformers/models/auto/image_processing_auto.py: AddedBitImageProcessorFastto the list of image processors for thebitmodel. [1] [2]src/transformers/models/bit/__init__.py: IncludedBitImageProcessorFastin the type checking imports.Documentation Updates:
docs/source/en/model_doc/bit.mdanddocs/source/ja/model_doc/bit.md: Added documentation entries for the newBitImageProcessorFastclass. [1] [2]Testing:
tests/models/bit/test_image_processing_bit.py: Added unit tests forBitImageProcessorFastto ensure proper functionality and integration.Dummy Objects:
src/transformers/utils/dummy_torchvision_objects.py: Added a dummy class forBitImageProcessorFastto handle cases wheretorchvisionis not available.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.