Skip to content

Idefics2 Fast Image processor - #37168

Open
sushmanthreddy wants to merge 8 commits into
huggingface:mainfrom
sushmanthreddy:Idefics
Open

sushmanthreddy wants to merge 8 commits into
huggingface:mainfrom
sushmanthreddy:Idefics

Conversation

@sushmanthreddy

Copy link
Copy Markdown
Contributor

close #36978

@github-actions
github-actions Bot marked this pull request as draft April 1, 2025 10:59
@github-actions

github-actions Bot commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

Hi 馃憢, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@sushmanthreddy sushmanthreddy changed the title Idefics Idefics2 Fast Image processor Apr 1, 2025
@sushmanthreddy

Copy link
Copy Markdown
Contributor Author

@yonigozlan

This is the Idefics 2 fast image processor ,got some issue closed that pr

@sushmanthreddy
sushmanthreddy marked this pull request as ready for review April 1, 2025 11:08
@github-actions
github-actions Bot requested review from ydshieh and yonigozlan April 1, 2025 11:08

@yonigozlan yonigozlan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sushmanthreddy ! Thanks a lot for working on this. Overall it looks great, but I'm actually working on a refactor of the processing in idefics2/idefics3/smolvlm family which will impact this PR, here's the PR in question: #37291

Basically it will change the processing of batched images to fully flattened images, so it should simplify this PR.

I advise waiting for this refactor to be merged before iterating on this PR, I'll ping here when it's done!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Contributions Welcome] Add Fast Image Processors

2 participants