Skip to content

Stable diffusion inpainting. - #904

Merged
patrickvonplaten merged 17 commits into
mainfrom
sd-inpainting
Oct 19, 2022
Merged

patrickvonplaten merged 17 commits into
mainfrom
sd-inpainting

Conversation

@patil-suraj

Copy link
Copy Markdown
Contributor

No description provided.

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Oct 19, 2022 •

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

Comment thread src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py Outdated
Comment thread src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py Outdated
@patrickvonplaten
patrickvonplaten marked this pull request as ready for review October 19, 2022 12:44

@patrickvonplaten patrickvonplaten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the PR looks very nice to me!
Could we add one nice ValueError check / explanation in the beginning why the unet has 9 input channels?
Guess it comes from 4 for the latent 3 for the masked image and 2 from the image or where does the 9 come from? Would be nice to wrap this info in a shape check / comment.

Apart from that good to go for me!

Comment thread tests/test_pipelines.py Outdated
@patrickvonplaten patrickvonplaten changed the title [wip] Stable diffusion inpainting. Stable diffusion inpainting. Oct 19, 2022
@patrickvonplaten
patrickvonplaten merged commit b35d88c into main Oct 19, 2022
@patil-suraj
patil-suraj deleted the sd-inpainting branch October 19, 2022 14:14
kumquatexpress pushed a commit to harvestlabs/diffusers that referenced this pull request Oct 19, 2022
* begin pipe

* add new pipeline

* add tests

* correct fast test

* up

* Update src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py

* Update tests/test_pipelines.py

* up

* up

* make style

* add fp16 test

* doc, comments

* up

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Co-authored-by: Anton Lozhkov <anton@huggingface.co>
prathikr pushed a commit to prathikr/diffusers that referenced this pull request Oct 26, 2022
* begin pipe

* add new pipeline

* add tests

* correct fast test

* up

* Update src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py

* Update tests/test_pipelines.py

* up

* up

* make style

* add fp16 test

* doc, comments

* up

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Co-authored-by: Anton Lozhkov <anton@huggingface.co>
PhaneeshB pushed a commit to nod-ai/diffusers that referenced this pull request Mar 1, 2023
yoonseokjin pushed a commit to yoonseokjin/diffusers that referenced this pull request Dec 25, 2023
* begin pipe

* add new pipeline

* add tests

* correct fast test

* up

* Update src/diffusers/pipelines/stable_diffusion/pipeline_stable_diffusion_inpaint.py

* Update tests/test_pipelines.py

* up

* up

* make style

* add fp16 test

* doc, comments

* up

Co-authored-by: Patrick von Platen <patrick.v.platen@gmail.com>
Co-authored-by: Anton Lozhkov <anton@huggingface.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants