Repository navigation
Renamed variables from single letter to better naming - #449
Merged
Merged
Conversation
q -> query k -> key v -> value b -> batch c -> channel h -> height w -> weight
daspartho
marked this pull request as draft
September 9, 2022 15:55
|
The documentation is not available anymore as the PR was closed or merged. |
missed some in the initial commit
daspartho
marked this pull request as ready for review
September 9, 2022 16:00
patil-suraj
reviewed
Sep 9, 2022
patil-suraj
left a comment
patil-suraj
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot, just a couple more changes!
As per code review suggestions, renamed x -> hidden_states and x_in -> residual
Contributor
Author
|
@patil-suraj renamed variable names as per suggestion :) |
patil-suraj
reviewed
Sep 9, 2022
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* renamed variable names q -> query k -> key v -> value b -> batch c -> channel h -> height w -> weight * rename variable names missed some in the initial commit * renamed more variable names As per code review suggestions, renamed x -> hidden_states and x_in -> residual * fixed minor typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on issue #198
Renamed single-letter variables to more explicit variables.
@patil-suraj could you check it?
Thanks :)