Repository navigation
Adding logging images to textual inversion. Issue 1837 - #1838
isamu-isozaki wants to merge 16 commits into
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
|
@patil-suraj @williamberman could you take a look here? |
|
sry, I'll fix the quality check in a bit |
|
Re-ping @patil-suraj @williamberman here |
|
Quality checks for the files inside examples/textual_inversion passed so I'm done with what I wanted to do I think. |
|
@patil-suraj can you check please? |
patil-suraj
left a comment
There was a problem hiding this comment.
Thanks a lot for the PR! Sorry to only come back to it now. The logic can be simplified a lot, for reference see
diffusers/examples/dreambooth/train_dreambooth_lora.py
Lines 910 to 944 in a66f2ba
Could you please update the PR with a similar logic as above. Thanks :)
|
@patil-suraj Thanks for the review! And will do |
|
@patil-suraj Should be fixed now! Tested with command I needed to modify 1 line of StableDiffusionPipeline so that text_encoder's dtype is fine even with mixed_precision |
…textual_log_img
This is the implementation of the idea of this issue
I added support for wandb if it is installed but will otherwise just log the images to args.output_dir/imgs/