Repository navigation
Fix active adapter detection for text encoders - #14961
Conversation
|
Let's wait for #14965 to get merged first. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Signed-off-by: Subodh Bansode <subodh171011@gmail.com>
e89f06d to
74e2c61
Compare
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks for fixing this, I confirmed that the test fails without the fix.
| "Fused lora should change the output", | ||
| ) | ||
|
|
||
| def test_get_active_adapters_text_encoder_only(self): |
There was a problem hiding this comment.
@Subodh-17 #14965 removes this monolithic tests/lora/utils.py tester. Could we move it to https://github.com/huggingface/diffusers/blob/122b1e11fd497c3eeef14b3b98ca26a60166e48b/tests/pipelines/testing_utils/lora.py ?
Signed-off-by: Subodh Bansode <subodh171011@gmail.com>
cfed9d0 to
f656aa9
Compare
|
/diffusers-bot pytest tests/pipelines -k "test_get_active_adapters_text_encoder_only" |
|
✅ |
Summary
Fixes an issue where
get_active_adapters()returns an empty list when a LoRA adapter is attached only to a text encoder.get_active_adapters()previously only inspectedModelMixincomponents, while text encoders inherit fromPreTrainedModel. This change includes both component types, matching the behavior already used by other LoRA adapter methods.Testing
test_get_active_adapters_text_encoder_onlygit diff --checkpassesFixes #14955